#2242: hotfix: prevent ConcurrentModificationException in TaskManager.addTask() - #2243
Open
laim2003 wants to merge 11 commits into
Open
#2242: hotfix: prevent ConcurrentModificationException in TaskManager.addTask()#2243laim2003 wants to merge 11 commits into
laim2003 wants to merge 11 commits into
Conversation
- Create a defensive copy of the tasks list before streaming to avoid ConcurrentModificationException when the list is modified by FX listeners - This resolves intermittent test failures in listContentsAreCoherent test that occur in CI environments with different thread scheduling - Fixes issue where TaskWindowTest fails on GitHub Actions
laim2003
added
test
laim2003
changed the title
Collaborator
Coverage Report for CI Build 30922852261Coverage increased (+0.03%) to 72.613%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
…fication-in-task-manager' into devonfw#2242-fix-concurrent-modification-in-task-manager
Contributor
Author
|
With the current state of the PR, the underlying issue is not fully resolved, but we at least are more stable in the tests. |
JoelAdbu
reviewed
Aug 3, 2026
| FxHelper.runFxSafe(() -> { | ||
| if (tasks.stream().anyMatch(t -> Objects.equals(t.getTaskId(), task.getTaskId()))) { | ||
| // Duplicate task — silently skip. Throwing here would crash the FX event loop | ||
| // when called from a background thread. |
Contributor
There was a problem hiding this comment.
Exception should be handled here
Contributor
Author
There was a problem hiding this comment.
I did not reintroduce an exception here, but I decided to simply log an error when this happens.
laim2003
marked this pull request as draft
August 4, 2026 11:57
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2242
Implemented changes:
Testing instructions
As stated in the Issue, reproducing this is quite hard. What you can do is, to run this test locally and to check whether this test succeeds locally and also here on GitHub.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal