#2182: add commandlet view with combobox to select and execute commandlets - #2213
#2182: add commandlet view with combobox to select and execute commandlets#2213Hiepiscus wants to merge 13 commits into
Conversation
…let-view' into 2182-basic-structure-for-commandlet-view
… selected commandlet
Coverage Report for CI Build 30266245727Coverage decreased (-0.09%) to 72.476%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions38 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
laim2003
left a comment
There was a problem hiding this comment.
Thanks for your PR 👍 however to be honest, I think we should really rework, how we will implement this UI-wise. Right now, when i click on "Commandlets", the whole screen simply gets replaced like this:
This does not really follow any user experience standards, besides the fact that i do not really see how I can navigate away from this screen?
Also, all commandlets get executed on the UI thread, which freezes the application.
Sadly we do not yet have any documented guidelines on how we implement changes in the UI as a process, which we should definitely change soon, but for now I think it will make sense that we first create a sketch in our Figma board to understand how we want the feature to look for the end user (https://www.figma.com/design/cEcWlvnNOS5xVE2kQFZe0R/IDEasy?node-id=207-2267). Maybe we can implement it as a separate tab for example? But we can also discuss this further in the Dailys.
This PR fixes #2182
Adds a new commandlet view that allows user to select a commandlet from a combobox, configure its parameters, and execute it so that IDEasy commands can be run from the GUI without using the command line.
Implemented changes:
CommandletController(new):CommandletManager. Parses the parameter text input and maps tokens to commandlet value properties then executes the commandlet viarunCommandlet.commandlet-view(new):MainController:openCommandlet()method to navigate from the main to commandlet view and connected to a new button.main-view: new navigation button for commandlet view.Testing instructions
AppLauncherCommandletsmvn 3.9.4)Runto executeChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal