Skip to content

#2186: create obsidian url updater - #2203

Open
JoelAdbu wants to merge 5 commits into
devonfw:mainfrom
JoelAdbu:feature/2186-create-obsidian-urlupdater
Open

#2186: create obsidian url updater#2203
JoelAdbu wants to merge 5 commits into
devonfw:mainfrom
JoelAdbu:feature/2186-create-obsidian-urlupdater

Conversation

@JoelAdbu

@JoelAdbu JoelAdbu commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2186

Implemented changes:

  1. Add Obsidian URL updater.
  2. Generate platform-specific download URLs from Obsidian GitHub releases.
  3. Add integration test and mocked release data.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run mvn clean test.
  2. Verify that ObsidianUrlUpdaterTest passes.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 22, 2026
@JoelAdbu JoelAdbu self-assigned this Jul 22, 2026
@JoelAdbu JoelAdbu added enhancement New feature or request urls ide-urls repo and related processes and features obsidian labels Jul 22, 2026
@JoelAdbu JoelAdbu moved this from 🆕 New to Team Review in IDEasy board Jul 22, 2026
@vivu001 vivu001 self-assigned this Jul 23, 2026
@vivu001

vivu001 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I’ve run the tests and everything passed successfully. The implementation looks good and follows a proper approach.
LGTM 👍

One minor remark: please update the changelog before merging.

@coveralls

coveralls commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 31100058000

Coverage increased (+0.09%) to 72.952%

Details

  • Coverage increased (+0.09%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 13 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

13 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/UpdateManager.java 13 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 17510
Covered Lines: 13316
Line Coverage: 76.05%
Relevant Branches: 7727
Covered Branches: 5095
Branch Coverage: 65.94%
Branches in Coverage %: Yes
Coverage Strength: 3.23 hits per line

💛 - Coveralls

@JoelAdbu
JoelAdbu requested a review from vivu001 July 29, 2026 06:00
@JoelAdbu
JoelAdbu force-pushed the feature/2186-create-obsidian-urlupdater branch from 052a88f to 5b5f563 Compare July 29, 2026 06:06
@vivu001
vivu001 removed their request for review July 30, 2026 09:34
@JoelAdbu JoelAdbu moved this from Team Review to 👀 In review in IDEasy board Jul 30, 2026
@JoelAdbu
JoelAdbu force-pushed the feature/2186-create-obsidian-urlupdater branch 3 times, most recently from 78ced36 to 98bdab9 Compare August 4, 2026 11:29
- Add Obsidian URL updater, test and release mock data
added Obsidian url updater to updateManager

# Conflicts:
#	url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java

# Conflicts:
#	url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java
- added arm64 updater for obsidian
- improved obsidian-releases mock
- add changelog
@JoelAdbu
JoelAdbu force-pushed the feature/2186-create-obsidian-urlupdater branch from 98bdab9 to 7efe13d Compare August 6, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request obsidian urls ide-urls repo and related processes and features

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Create ObsidianUrlUpdater

3 participants