#1933 Added GUI console pane - #2053
Conversation
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
…t-for-gui' into devonfw#1785-implement-modals-in-idecontext
- Added functionality, that selecting a different project now switches the IdeContext to the new project.
…plementation' into devonfw#1802-state-management-implementation
…r other ui feature branches
- added DI for IdeGuiStateManager.switchContext
…reading the list of workspaces/projects instead of reading those from the UI
…nager, when switchContext(Path rootDirectory, ...) is called.
This reverts commit 6f92d93.
…plementation' into devonfw#1802-state-management-implementation
…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter
… getInstance()) (see previous commit)
…can be extended by tests
…plementation' into devonfw#1802-state-management-implementation
hohwille
left a comment
There was a problem hiding this comment.
@laim2003 thanks for your PR. Great job 👍
There is still one review comment from @oanding-blrng unresolved that you should have a look.
The only additional thing I want to point out during the review is that PR #2037 just introduced an "application icon" for IDEasy in addition to our logo.
In this PR you also add `terminal.png" and I guess it does not represent IDEasy itself but the console like a terminal. However, both icons look quite similar. Maybe we want to adjust to avoid confusion. However, should not block the merge.
Please note that you have to resolve some conflicts so this can be merged.
# Conflicts: # CHANGELOG.adoc # gui/src/main/java/com/devonfw/ide/gui/MainController.java # gui/src/main/java/com/devonfw/ide/gui/context/IdeGuiContext.java # gui/src/main/resources/com/devonfw/ide/gui/main-view.fxml # gui/src/test/java/com/devonfw/ide/gui/AppBaseTest.java
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
…se UI performance Signed-off-by: laim2003 <luk.faber@gmx.de>
|
I'm currently working on migrating the implementation to a ListView based implementation. This allows us much more flexibility in working with log messages such as filtering etc. I think it makes sense to get this right from the start, as otherwise we will have to completely overhaul this later on. |
Signed-off-by: laim2003 <luk.faber@gmx.de>
…felxibility reasons. Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
… into devonfw#1933-gui-console-window
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
…timestamps Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
|
I just also realized what this new listView-based design allows us to do: Because we handle any Log output in the console via ListItems, we can fully customize what each list item displays. This allows us to integrate dialogues and choices into the console (potentially). As a first step, I will create a Figma design. |
This PR fixes #1933
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
1a. (Team) Review
1b. Retesting
ide gui2. Then:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal