Conversation
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@thepetk Need you to sign off to fix DCO
Jdubrick
left a comment
Jdubrick
left a comment
There was a problem hiding this comment.
lgtm after DCO is fixed
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
patch-upload-artifact
branch
from
b93b537 to
de59619
Compare
|
New changes are detected. LGTM label has been removed. |
|
fff you go through github UI to fix something simple and then you take double the time to fix what you have added :D signed :D |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
/lgtm
This could be taken care of by Konflux renovate, could update the renovate config to include github actions.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: thepetk <thepetk@gmail.com>
3 participants
Description of Changes
Updates the upload-artifact action as its version is no longer supported.
Related Issue(s)
Partially fixes devfile/api#1675
Acceptance Criteria
Update the sidebar if there is a new file added or an existing filename is changed
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.