Skip to content

feat: add modified timestamp#1281

Closed
crowlKats wants to merge 3 commits intomainfrom
add-modified-timestamp
Closed

feat: add modified timestamp#1281
crowlKats wants to merge 3 commits intomainfrom
add-modified-timestamp

Conversation

@crowlKats
Copy link
Copy Markdown
Member

Closes #1280

Comment thread _components/Feedback.tsx
(
<div class="mt-4">
This page was last modified on{" "}
<time datetime={modifiedDate.toString()}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<time datetime={modifiedDate.toString()}>
<time datetime={modifiedDate.toISOString()}>

The toString() method of Date instances returns a string representing this date interpreted in the local timezone.

toString() returns localized date; but <time> requires datetime in ISO8601 format.

@bartlomieju
Copy link
Copy Markdown
Member

Closing in favor of #2982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add last modified timestmp to content pages in docs

4 participants