fix(webapp): add overridesBySpanId and environmentId filter for self-hosted OTEL spans#16
Open
deepshekhardas wants to merge 1 commit into
Open
fix(webapp): add overridesBySpanId and environmentId filter for self-hosted OTEL spans#16deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
…hosted OTEL spans (fix triggerdotdev#2821)
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/webapp/app/v3/eventRepository/eventRepository.server.ts">
<violation number="1" location="apps/webapp/app/v3/eventRepository/eventRepository.server.ts:996">
P1: `traceId` is optional in `#getSpanEvent`, so ancestor traversal still performs unscoped span lookups. This can attach parents from another trace when span IDs collide, producing incorrect span status and duration overrides.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| }: { | ||
| storeTable: TaskEventStoreTable; | ||
| spanId: string; | ||
| traceId?: string; |
There was a problem hiding this comment.
P1: traceId is optional in #getSpanEvent, so ancestor traversal still performs unscoped span lookups. This can attach parents from another trace when span IDs collide, producing incorrect span status and duration overrides.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/webapp/app/v3/eventRepository/eventRepository.server.ts, line 996:
<comment>`traceId` is optional in `#getSpanEvent`, so ancestor traversal still performs unscoped span lookups. This can attach parents from another trace when span IDs collide, producing incorrect span status and duration overrides.</comment>
<file context>
@@ -972,22 +985,29 @@ export class EventRepository implements IEventRepository {
}: {
storeTable: TaskEventStoreTable;
spanId: string;
+ traceId?: string;
environmentId: string;
startCreatedAt: Date;
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes triggerdotdev#2821
Changes
Root cause
Self-hosted instances were not filtering span queries by \environmentId, causing OpenTelemetry spans to not display in timeline.
Summary by cubic
Fixes triggerdotdev#2821. Scopes OTEL trace queries to the current environment and surfaces span overrides so self-hosted timelines show the correct spans.
findTraceEventsbyenvironmentIdto stop cross-environment span mixing.getSpanEventbytraceId(when provided) for precise span lookup.overridesBySpanIdingetTraceSummary(cancelled, isError, duration) derived from ancestor spans.Written for commit b0a7682. Summary will update on new commits.