Merged
Conversation
reyreavman
force-pushed
the
feat/sbom/resolve-version-unknown
branch
2 times, most recently
from
ab4ff73 to
7a90b88
Compare
nervgh
requested changes
Mar 10, 2026
reyreavman
force-pushed
the
feat/sbom/resolve-version-unknown
branch
from
aab2894 to
ef73b19
Compare
nervgh
approved these changes
Mar 17, 2026
reyreavman
force-pushed
the
feat/sbom/resolve-version-unknown
branch
from
ef73b19 to
20e3367
Compare
alexey-igrychev
approved these changes
Apr 14, 2026
Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
- Move _fixtures/sbom-go-replace/state0 → _fixtures/sbom/go_replace - Add git tag v1.0.0 in test setup for deterministic version - Assert exact version v1.0.0 instead of just not-UNKNOWN Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
Local.TagCommit was missing — only Remote had an implementation. The Base panic stub was being called at runtime when resolving Go module versions from git tags. Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
Syft writes "(devel)" (not "UNKNOWN") for local replace modules, and uses the filesystem path (e.g. "./mylib") as component name instead of the module name. Fix both: - Match (devel) in addition to UNKNOWN - Include local replace paths (New.Path) in match targets - Handle URL-encoded %28devel%29 in PURL Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
…2e test Syft records local replace modules with filesystem path (./mylib) as component name, not the module name (example.com/mylib). Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
When Syft records a local replace module with filesystem path as name (e.g. ./mylib), replace it with the actual module name from go.mod replace directive (e.g. example.com/mylib) and rebuild PURL accordingly. Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
…ocessing Replace gitRepo/commit/imageContext params in ConvergeWithMerge with []BOMPatcher — a slice of transform functions. Each patcher is a closure built by the caller. Adding a new patcher requires only appending a new function to the slice, no signature changes. Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
…ent patcher PatchComponents(bom, match, patch) iterates BOM components and applies a transformation to each matching one. ResolveUnknownGoVersions is now built on top of it. New patchers can reuse the same traversal. Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
reyreavman
force-pushed
the
feat/sbom/resolve-version-unknown
branch
from
20e3367 to
0744e4c
Compare
Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
reyreavman
force-pushed
the
feat/sbom/resolve-version-unknown
branch
from
0744e4c to
b892d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.