Skip to content

Display password metavar value as TEXT, not STRING#1734

Merged
rolandwalker merged 1 commit intomainfrom
RW/display-password-metavar-text
Mar 23, 2026
Merged

Display password metavar value as TEXT, not STRING#1734
rolandwalker merged 1 commit intomainfrom
RW/display-password-metavar-text

Conversation

@rolandwalker
Copy link
Contributor

Description

Display password metavar value as TEXT, not STRING, to match other items in the helpdoc

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

to match other items in the helpdoc
@rolandwalker rolandwalker self-assigned this Mar 21, 2026
@github-actions
Copy link

  1. Low Missing regression test for CLI help metavar change
    File: mycli/main.py:146
    The PR changes only display text (STRING -> TEXT) for the --password option type, but there is no test asserting --help output for this option. Add a small CliRunner test that checks the --password help line includes TEXT so future refactors of the custom ParamType don’t silently revert behavior.

No correctness or security bugs were identified in this patch beyond that test coverage gap.

@rolandwalker rolandwalker merged commit 28e27da into main Mar 23, 2026
10 checks passed
@rolandwalker rolandwalker deleted the RW/display-password-metavar-text branch March 23, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants