adding memory and disk usage stats to bench tests#591
Merged
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
jshook
reviewed
Jan 16, 2026
jvector-examples/src/main/java/io/github/jbellis/jvector/example/Grid.java
Show resolved
Hide resolved
jshook
reviewed
Jan 16, 2026
jvector-examples/src/main/java/io/github/jbellis/jvector/example/Grid.java
Show resolved
Hide resolved
jshook
reviewed
Jan 16, 2026
...main/java/io/github/jbellis/jvector/example/benchmarks/diagnostics/BenchmarkDiagnostics.java
Show resolved
Hide resolved
jshook
reviewed
Jan 16, 2026
...src/main/java/io/github/jbellis/jvector/example/benchmarks/diagnostics/DiskUsageMonitor.java
Outdated
Show resolved
Hide resolved
jshook
approved these changes
Jan 16, 2026
Contributor
jshook
left a comment
There was a problem hiding this comment.
I've approved this, but please see my comments regarding notify. I think you might have a better way to implement this which is well supported and much more efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new columns to the BenchYAML tests measuring memory and disk usage. The output looks as follows: