Conversation
Fixes #333 solved
jeestr4d
commented
Mar 3, 2026
Collaborator
Author
jeestr4d
left a comment
jeestr4d
left a comment
There was a problem hiding this comment.
Lab output (logic editted):
[Check 84/90] Ctrlr and Node svccore count... FAIL - UPGRADE FAILURE!!
Node ID svccoreCtrlr/Node Count
------- -----------------------
1 3
101 14
102 3
103 11
104 1
105 15
201 5
202 5
210 3
600 11
601 1
Recommended Action: Contact TAC to remove the exceeding svccoreCtrlr, svccoreNode MOs before upgrade.
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#ctrlr-and-node-svccore-count
Local pytest
===================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.12.12, pytest-7.4.0, pluggy-1.2.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
collected 6 items
tests/checks/svccore_ctrl_and_node_check/test_svccore_ctrl_and_node_check.py::test_logic[icurl_outputs0-None-MANUAL CHECK REQUIRED]
---------------------------------------------------------------------------------------- live log setup ----------------------------------------------------------------------------------------
[18:10:59.379 INFO init_system:6096(MainThread)] Cleaning up previous run files in preupgrade_validator_logs/
[18:10:59.380 INFO init_system:6098(MainThread)] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
---------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------
[18:10:59.381 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
[18:10:59.381 INFO _start_thread:1105(MainThread)] (svccore_ctrl_and_node_check) Starting thread.
[18:10:59.382 INFO wrapper:1349(svccore_ctrl_and_node_check)] Start svccore_ctrl_and_node_check
[18:10:59.382 INFO update_result:1191(svccore_ctrl_and_node_check)] Finalized result in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
PASSED [ 16%]
tests/checks/svccore_ctrl_and_node_check/test_svccore_ctrl_and_node_check.py::test_logic[icurl_outputs1-6.2(1b)-N/A]
---------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------
[18:10:59.396 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
[18:10:59.396 INFO _start_thread:1105(MainThread)] (svccore_ctrl_and_node_check) Starting thread.----------| 0/1 checks completed
[18:10:59.396 INFO wrapper:1349(svccore_ctrl_and_node_check)] Start svccore_ctrl_and_node_check
[18:10:59.396 INFO update_result:1191(svccore_ctrl_and_node_check)] Finalized result in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
PASSED [ 33%]
tests/checks/svccore_ctrl_and_node_check/test_svccore_ctrl_and_node_check.py::test_logic[icurl_outputs2-6.0(3e)-PASS]
---------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------
[18:10:59.410 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
[18:10:59.410 INFO _start_thread:1105(MainThread)] (svccore_ctrl_and_node_check) Starting thread.----------| 0/1 checks completed
[18:10:59.410 INFO wrapper:1349(svccore_ctrl_and_node_check)] Start svccore_ctrl_and_node_check
[18:10:59.411 INFO update_result:1191(svccore_ctrl_and_node_check)] Finalized result in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
PASSED [ 50%]
tests/checks/svccore_ctrl_and_node_check/test_svccore_ctrl_and_node_check.py::test_logic[icurl_outputs3-6.0(3e)-FAIL - UPGRADE FAILURE!!]
---------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------
[18:10:59.423 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
[18:10:59.423 INFO _start_thread:1105(MainThread)] (svccore_ctrl_and_node_check) Starting thread.----------| 0/1 checks completed
[18:10:59.424 INFO wrapper:1349(svccore_ctrl_and_node_check)] Start svccore_ctrl_and_node_check
[18:10:59.424 INFO update_result:1191(svccore_ctrl_and_node_check)] Finalized result in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
PASSED [ 66%]
tests/checks/svccore_ctrl_and_node_check/test_svccore_ctrl_and_node_check.py::test_logic[icurl_outputs4-6.0(3e)-FAIL - UPGRADE FAILURE!!]
---------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------
[18:10:59.436 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
[18:10:59.436 INFO _start_thread:1105(MainThread)] (svccore_ctrl_and_node_check) Starting thread.----------| 0/1 checks completed
[18:10:59.436 INFO wrapper:1349(svccore_ctrl_and_node_check)] Start svccore_ctrl_and_node_check
[18:10:59.437 INFO update_result:1191(svccore_ctrl_and_node_check)] Finalized result in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
PASSED [ 83%]
tests/checks/svccore_ctrl_and_node_check/test_svccore_ctrl_and_node_check.py::test_logic[icurl_outputs5-6.0(3e)-FAIL - UPGRADE FAILURE!!]
---------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------
[18:10:59.450 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
[18:10:59.450 INFO _start_thread:1105(MainThread)] (svccore_ctrl_and_node_check) Starting thread.
[18:10:59.450 INFO wrapper:1349(svccore_ctrl_and_node_check)] Start svccore_ctrl_and_node_check
[18:10:59.451 INFO update_result:1191(svccore_ctrl_and_node_check)] Finalized result in preupgrade_validator_logs/json_results/svccore_ctrl_and_node_check.json
PASSED [100%]
====================================================================================== 6 passed in 0.10s ======================================================================================
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333 solved