Add arg to define thread limit - to throttle concurrent API calls when required#355
Open
Add arg to define thread limit - to throttle concurrent API calls when required#355
Conversation
Collaborator
monrog2
commented
Feb 25, 2026
monrog2
commented
monrog2
commented
Feb 26, 2026
Comment on lines
+1517
to
+1521
| try: | ||
| print(objects, sep=sep, end=end, file=sys.stdout) | ||
| sys.stdout.flush() | ||
| except OSError: | ||
| pass |
Collaborator
Author
There was a problem hiding this comment.
pytests were intermittently failing with Bad File Descriptor
monrog2
commented
Feb 26, 2026
Comment on lines
+53
to
+63
| # Join each task thread to ensure any in-progress prints complete before | ||
| # capsys.readouterr() is called. Without this there is a race where a | ||
| # thread passes the `if not global_timeout` check and then tries to print | ||
| # after pytest has already torn down the captured stdout fd, causing | ||
| # OSError: [Errno 9] Bad file descriptor. | ||
| for thread in tm.threads: | ||
| try: | ||
| thread.join(timeout=1.5) | ||
| except RuntimeError: | ||
| pass # thread was never started | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Handling another scenario where Bad File descriptor would intermittently fail this specific pytest
monrog2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.