Skip to content

Discuss the meaning of "relational".#367

Open
jd-foster wants to merge 3 commits intodatacarpentry:mainfrom
jd-foster:jdf/intro-rel
Open

Discuss the meaning of "relational".#367
jd-foster wants to merge 3 commits intodatacarpentry:mainfrom
jd-foster:jdf/intro-rel

Conversation

@jd-foster
Copy link
Copy Markdown
Contributor

Based on the nice suggested change of @chbrandt in #353, since the block on "relational database" is somewhat vague and confusing.


Co-authored-by: Carlos H Brandt 482051+chbrandt@users.noreply.github.com

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 12, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/sql-ecology-lesson/compare/md-outputs..md-outputs-PR-367

The following changes were observed in the rendered markdown documents:

 00-sql-introduction.md | 16 +++++++++++-----
 md5sum.txt             |  2 +-
 2 files changed, 12 insertions(+), 6 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-03-31 11:00:19 +0000

@jd-foster jd-foster requested a review from adamancer October 12, 2023 01:13
github-actions bot pushed a commit that referenced this pull request Oct 12, 2023
github-actions bot pushed a commit that referenced this pull request Oct 12, 2023
Copy link
Copy Markdown
Contributor

@adamancer adamancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I'm on the fence about these changes. I think the clarifications could be useful, but to me the real problem with this section is how dense the preceding definition block is. Keys could probably have their own definition block, for example, along with the short paragraph about how they are used to establish/enforce relationships between tables.

@jd-foster
Copy link
Copy Markdown
Contributor Author

Thanks for the review. I need to think further on how to organise the flow.

@jd-foster jd-foster requested a review from adamancer March 31, 2026 11:00
github-actions bot pushed a commit that referenced this pull request Mar 31, 2026
@jd-foster
Copy link
Copy Markdown
Contributor Author

Getting back to this - I tried to follow your comments from before and I am happier with this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants