Discuss the meaning of "relational".#367
Discuss the meaning of "relational".#367jd-foster wants to merge 3 commits intodatacarpentry:mainfrom
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/sql-ecology-lesson/compare/md-outputs..md-outputs-PR-367 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-03-31 11:00:19 +0000 |
adamancer
left a comment
There was a problem hiding this comment.
Thanks for working on this! I'm on the fence about these changes. I think the clarifications could be useful, but to me the real problem with this section is how dense the preceding definition block is. Keys could probably have their own definition block, for example, along with the short paragraph about how they are used to establish/enforce relationships between tables.
|
Thanks for the review. I need to think further on how to organise the flow. |
|
Getting back to this - I tried to follow your comments from before and I am happier with this version. |
Based on the nice suggested change of @chbrandt in #353, since the block on "relational database" is somewhat vague and confusing.
Co-authored-by: Carlos H Brandt 482051+chbrandt@users.noreply.github.com