Open
Conversation
heyujiao99
commented
Apr 14, 2025
- Add support for TPCDS-v4.0.0
- add queries generated by the official TPC-DS-Tools-v4.0.0 ( tpc.org)
- add entries for tpcds-v4.0.0 in TPCDS_4_0_Queries.scala and TPCDS.scala
- since v2.6.0 the field 'c_last_review_date' was renamed to 'c_last_review_date_sk' (used in q30). For backward compatibility, changed it back to 'c_last_review_date' in q30
- The tpcds-kit compatible with v4.0.0 can be found at tpcds-kit
- Tested on Linux platform with 1TB dataset.
|
All of the old spec docs I've looked at reference 'c_last_review_date**_sk**' and have this as an identity column which would map to a int, not a string. I haven't found any other instances of this column being used this way, I've only seen it in this repo. Might it be worth just updating this tool to generate the proper int field w/ '_sk'? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.