perf: emit only changed column databricks_tags keys in ALTER COLUMN SET TAGS - #1668
Open
sd-db wants to merge 2 commits into
Open
perf: emit only changed column databricks_tags keys in ALTER COLUMN SET TAGS#1668sd-db wants to merge 2 commits into
sd-db wants to merge 2 commits into
Conversation
Unchanged columns are still skipped; within a changed column only new or updated keys are sent, and remote-only tags are never unset.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
saishreeeee
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks_tagsdiffs still skip columns with no changes.ALTER COLUMN … SET TAGSnow includes only new or updated keys, not the full desired map for that column.Test plan
tests/unit/relation_configs/test_column_tags_config.py(includingtest_get_diff__omits_unchanged_keys_within_column)databricks_uc_sql_endpoint:TestIncrementalColumnTags,TestColumnTagsTable