test: reproduce config-sync dropping remote cluster additions - #6630
Closed
ilyakuz-db wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #6631, which uses the same commits on a branch in
databricks/cli.Changes
Add an acceptance test showing that #6531 makes
bundle config-remote-sync --savesilently ignore a remotely added Spark setting on a job cluster with a policy.Why
The test's policy fixes only
custom_tags.PolicyTag; it leavesspark_confunrestricted. After deployment, the test addsspark.sql.shuffle.partitions: "7"to the job's task cluster through the Jobs API. Config-sync should copy this change intodatabricks.yml:Main produces this diff. With #6531, config-sync reports
No changes detectedand leaves YAML unchanged. The new rule skips remote-only additions whenever the cluster haspolicy_id, without checking whether the policy defines the field.This test-only PR is stacked on #6531 and intentionally fails until that regression is fixed.
Tests
9caaff0c): the exact acceptance test passes locally with deployment history off/on and one2-dogfoodwith history off. Snapshot generated by running main.8aeb76c4): the same local and cloud runs fail because the YAML diff is missing.libs/patchwheelfailures (ModuleNotFoundError: myproj).This PR was written by Codex.