You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Databricks CLI supports job_runs as a bundle resource, but PyDABs had no equivalent model or resource registration. This prevented Python bundle definitions from creating job runs or referencing jobs defined in the same load_resources function.
This change brings job_runs in line with existing PyDABs resources such as jobs, schemas, and volumes. Job dependencies are expressed through normal bundle references, for example resources.jobs.my_job.id.
Tests
Ran the complete PyDABs unit test suite: 245 tests passed.
Ran Pyright: zero errors.
Added and ran the bundle/python/job-runs-support acceptance test.
Verified the acceptance test with both DMS configurations under the direct deployment engine.
@denik -- recent work in .nextchanges/bundles/, python/codegen/codegen_tests/
Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.
Hi @hejcman-enverus, thanks for the PR.
We are currently consolidating support for all PyDABs resources in PR #6528 . Since that will cover this functionality and serve as our path forward, I'll be closing this PR. We really appreciate your time and effort here sorry for the overlap!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
job_runsresource.Resources.job_runsandResources.add_job_run(), including resource merging throughload_resources.job_run_mutatorsupport and registerjob_runas a PyDABs resource type.Example usage
Why
The Databricks CLI supports
job_runsas a bundle resource, but PyDABs had no equivalent model or resource registration. This prevented Python bundle definitions from creating job runs or referencing jobs defined in the sameload_resourcesfunction.This change brings
job_runsin line with existing PyDABs resources such as jobs, schemas, and volumes. Job dependencies are expressed through normal bundle references, for exampleresources.jobs.my_job.id.Tests
bundle/python/job-runs-supportacceptance test.