Round-trip pipeline parameters in the test server#5942
Open
radakam wants to merge 1 commit into
Open
Conversation
Collaborator
Integration test reportCommit: b55cc8d
10 interesting tests: 4 SKIP, 3 flaky, 3 RECOVERED
Top 9 slowest tests (at least 2 minutes):
|
radakam
changed the title
radakam
force-pushed
the
fix-testserver-pipeline-parameters
branch
from
July 16, 2026 10:37
0106047 to
43d5490
Compare
The fake pipelines handler unmarshals the create/update body into pipelines.PipelineSpec, which has no parameters field (it lives on CreatePipeline/EditPipeline and is echoed on the top-level GetPipelineResponse.Parameters). So a re-read never returned it and the direct engine planned a perpetual update for any pipeline that set parameters. Decode that request-only field separately and set it on the stored GetPipelineResponse. Adds an acceptance test that deploys a pipeline with parameters and asserts the plan is a no-op.
radakam
force-pushed
the
fix-testserver-pipeline-parameters
branch
from
July 16, 2026 10:40
43d5490 to
b55cc8d
Compare
radakam
marked this pull request as ready for review
July 16, 2026 12:20
andrewnester
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The fake pipelines handler decoded the create/update body into
pipelines.PipelineSpec, which has noparametersfield — it lives onCreatePipeline/EditPipelineand is echoed back onGetPipelineResponse.Parameters. Decode that request-only field separately and mirror it on the storedGetPipelineResponse, matching backend behavior.Why
Because the test server dropped
parameterson read-back, a re-read never returned it and the direct engine planned a perpetual update for any pipeline that setparameters. This gap was found by fuzz testing.Tests
Adds an acceptance test that deploys a pipeline with
parameters, assertsbundle planis a no-op, and confirms a redeploy issues no update call. Verified to fail without the fix.