Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/appkit/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export type {
StreamExecutionSettings,
} from "shared";
export { isSQLTypeMarker, sql } from "shared";
export { analytics } from "./analytics";
export { CacheManager } from "./cache";
export { getExecutionContext } from "./context";
export { createApp } from "./core";
Expand All @@ -31,7 +30,7 @@ export {
} from "./errors";
// Plugin authoring
export { Plugin, toPlugin } from "./plugin";
export { server } from "./server";
export { analytics, server } from "./plugins";
// Telemetry (for advanced custom telemetry)
export {
type Counter,
Expand Down
2 changes: 1 addition & 1 deletion packages/appkit/src/plugin/dev-reader.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { randomUUID } from "node:crypto";
import type { TunnelConnection } from "shared";
import { isRemoteTunnelAllowedByEnv } from "@/server/remote-tunnel/gate";
import { isRemoteTunnelAllowedByEnv } from "@/plugins/server/remote-tunnel/gate";
import { TunnelError } from "../errors";
import { createLogger } from "../logging/logger";

Expand Down
2 changes: 1 addition & 1 deletion packages/appkit/src/plugin/tests/dev-reader.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { beforeEach, describe, expect, test, vi } from "vitest";
import { TunnelError } from "../../errors";

// Mock the gate to allow remote tunnel in tests
vi.mock("@/server/remote-tunnel/gate", () => ({
vi.mock("@/plugins/server/remote-tunnel/gate", () => ({
isRemoteTunnelAllowedByEnv: () => true,
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import type {
SQLTypeMarker,
StreamExecutionSettings,
} from "shared";
import { SQLWarehouseConnector } from "../connectors";
import { SQLWarehouseConnector } from "../../connectors";
import {
getCurrentUserId,
getWarehouseId,
getWorkspaceClient,
} from "../context";
import { createLogger } from "../logging/logger";
import { Plugin, toPlugin } from "../plugin";
} from "../../context";
import { createLogger } from "../../logging/logger";
import { Plugin, toPlugin } from "../../plugin";
import { queryDefaults } from "./defaults";
import { QueryProcessor } from "./query";
import type {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { createHash } from "node:crypto";
import type { sql } from "@databricks/sdk-experimental";
import { isSQLTypeMarker, type SQLTypeMarker, sql as sqlHelpers } from "shared";
import { getWorkspaceId } from "../context";
import { ValidationError } from "../errors";
import { getWorkspaceId } from "../../context";
import { ValidationError } from "../../errors";

type SQLParameterValue = SQLTypeMarker | null | undefined;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
} from "@tools/test-helpers";
import { sql } from "shared";
import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
import { ServiceContext } from "../../context/service-context";
import { ServiceContext } from "../../../context/service-context";
import { AnalyticsPlugin, analytics } from "../analytics";
import type { IAnalyticsConfig } from "../types";

Expand Down Expand Up @@ -45,7 +45,7 @@ const { mockCacheStore, mockCacheInstance } = vi.hoisted(() => {
return { mockCacheStore: store, mockCacheInstance: instance };
});

vi.mock("../../cache", () => ({
vi.mock("../../../cache", () => ({
CacheManager: {
getInstanceSync: vi.fn(() => mockCacheInstance),
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { mockServiceContext } from "@tools/test-helpers";
import { sql } from "shared";
import { afterEach, beforeEach, describe, expect, test } from "vitest";
import { ServiceContext } from "../../context/service-context";
import { ServiceContext } from "../../../context/service-context";
import { QueryProcessor } from "../query";

describe("QueryProcessor", () => {
Expand Down
2 changes: 2 additions & 0 deletions packages/appkit/src/plugins/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from "./analytics";
export * from "./server";
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import path from "node:path";
import dotenv from "dotenv";
import express from "express";
import type { PluginPhase } from "shared";
import { ServerError } from "../errors";
import { createLogger } from "../logging/logger";
import { Plugin, toPlugin } from "../plugin";
import { instrumentations } from "../telemetry";
import { ServerError } from "../../errors";
import { createLogger } from "../../logging/logger";
import { Plugin, toPlugin } from "../../plugin";
import { instrumentations } from "../../telemetry";
import { RemoteTunnelController } from "./remote-tunnel/remote-tunnel-controller";
import { StaticServer } from "./static-server";
import type { ServerConfig } from "./types";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Server as HTTPServer } from "node:http";
import type express from "express";
import { createLogger } from "../../logging/logger";
import type { DevFileReader } from "../../plugin/dev-reader";
import { createLogger } from "../../../logging/logger";
import type { DevFileReader } from "../../../plugin/dev-reader";
import {
hasDevQuery,
isLocalDev,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { fileURLToPath } from "node:url";
import type express from "express";
import type { TunnelConnection } from "shared";
import { WebSocketServer } from "ws";
import { createLogger } from "../../logging/logger";
import { createLogger } from "../../../logging/logger";
import {
generateTunnelIdFromEmail,
getConfigScript,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { afterAll, beforeAll, describe, expect, test } from "vitest";
process.env.DATABRICKS_APP_PORT = "8000";
process.env.FLASK_RUN_HOST = "0.0.0.0";

import { ServiceContext } from "../../context/service-context";
import { createApp } from "../../core";
import { Plugin, toPlugin } from "../../plugin";
import { ServiceContext } from "../../../context/service-context";
import { createApp } from "../../../core";
import { Plugin, toPlugin } from "../../../plugin";
import { server as serverPlugin } from "../index";

// Integration tests - actually start server and make HTTP requests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ vi.mock("express", () => {
});

// Mock dependencies before imports
vi.mock("../../telemetry", () => ({
vi.mock("../../../telemetry", () => ({
TelemetryManager: {
getProvider: vi.fn().mockReturnValue({
getTracer: vi.fn().mockReturnValue({ startActiveSpan: vi.fn() }),
Expand All @@ -80,7 +80,7 @@ vi.mock("../../telemetry", () => ({
},
}));

vi.mock("../../cache", () => ({
vi.mock("../../../cache", () => ({
CacheManager: {
getInstanceSync: vi.fn().mockReturnValue({
get: vi.fn(),
Expand All @@ -90,7 +90,7 @@ vi.mock("../../cache", () => ({
},
}));

vi.mock("../../utils", () => ({
vi.mock("../../../utils", () => ({
validateEnv: vi.fn(),
deepMerge: vi.fn((a, b) => ({ ...a, ...b })),
}));
Expand All @@ -110,7 +110,7 @@ const { mockLoggerDebug, mockLoggerInfo, mockLoggerWarn, mockLoggerError } =
mockLoggerWarn: vi.fn(),
mockLoggerError: vi.fn(),
}));
vi.mock("../../logging/logger", () => ({
vi.mock("../../../logging/logger", () => ({
createLogger: vi.fn(() => ({
debug: mockLoggerDebug,
info: mockLoggerInfo,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { BasePluginConfig } from "shared";
import type { Plugin } from "../plugin";
import type { Plugin } from "../../plugin";

export interface ServerConfig extends BasePluginConfig {
port?: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import path from "node:path";
import type express from "express";
import type { ViteDevServer as ViteDevServerType } from "vite";
import { mergeConfigDedup } from "@/utils";
import { ServerError } from "../errors";
import { createLogger } from "../logging/logger";
import { appKitTypesPlugin } from "../type-generator/vite-plugin";
import { ServerError } from "../../errors";
import { createLogger } from "../../logging/logger";
import { appKitTypesPlugin } from "../../type-generator/vite-plugin";
import { BaseServer } from "./base-server";
import type { PluginEndpoints } from "./utils";

Expand Down
12 changes: 6 additions & 6 deletions packages/appkit/tsdown.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ export default defineConfig([
tsconfig: "./tsconfig.json",
copy: [
{
from: "src/server/remote-tunnel/index.html",
to: "dist/server/remote-tunnel/index.html",
from: "src/plugins/server/remote-tunnel/index.html",
to: "dist/plugins/server/remote-tunnel/index.html",
},
{
from: "src/server/remote-tunnel/wait.html",
to: "dist/server/remote-tunnel/wait.html",
from: "src/plugins/server/remote-tunnel/wait.html",
to: "dist/plugins/server/remote-tunnel/wait.html",
},
{
from: "src/server/remote-tunnel/denied.html",
to: "dist/server/remote-tunnel/denied.html",
from: "src/plugins/server/remote-tunnel/denied.html",
to: "dist/plugins/server/remote-tunnel/denied.html",
},
],
},
Expand Down