Updated the configuration for version release#1594
Open
Conversation
105dd56 to
9fbbc72
Compare
f818311 to
78b49d6
Compare
7570872 to
b4c35ba
Compare
892cabc to
fc3556d
Compare
Contributor
itsankit-google
left a comment
There was a problem hiding this comment.
This build is only used for non-snapshot releases which are tagged.
So, there is no need to maintain the step of Publish to Maven Central.
Also we can remove this step Get Secrets from GCP Secret Manager.
.github/workflows/tag-release.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright © 2022 Cask Data, Inc. | |||
| # Copyright © 2025 Cask Data, Inc. | |||
updated updated updated updated updated updated Set up Maven profiles for release and snapshot updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated updated
Author
Understood. Done |
| run: | | ||
| gcloud builds submit . \ | ||
| --config=cloudbuild-release.yaml \ | ||
| --project='cdapio-github-builds' \ |
Contributor
There was a problem hiding this comment.
we can skip adding project in the build since the runner is running in the same project as the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.