Conversation
Update ARRAY_API_TESTS_VERSION to 2025.12
There was a problem hiding this comment.
Pull request overview
This PR updates the Array API test suite version from 2024.12 to 2025.12 in the GitHub Actions CI workflow. The change affects only the testing infrastructure, not the actual implementation code.
Changes:
- Update
ARRAY_API_TESTS_VERSIONenvironment variable from 2024.12 to 2025.12 in the CI workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| ARRAY_API_TESTS_MODULE: array_api_compat.${{ inputs.module-name || inputs.package-name }} | ||
| ARRAY_API_TESTS_VERSION: 2024.12 | ||
| ARRAY_API_TESTS_VERSION: 2025.12 |
There was a problem hiding this comment.
The CI test version is being updated to 2025.12, but the actual implementation still declares support for 2024.12 in multiple places. There is a discrepancy between what's being tested and what the code declares it supports. The following files should be reviewed and potentially updated to maintain consistency:
array_api_compat/common/_helpers.py(line 59) -_API_VERSIONSstill only includes "2024.12"array_api_compat/numpy/__init__.py(line 29) -__array_api_version__is "2024.12"array_api_compat/cupy/__init__.py(line 15) -__array_api_version__is "2024.12"array_api_compat/dask/array/__init__.py(line 12) -__array_api_version__is "2024.12"array_api_compat/torch/__init__.py(line 16) -__array_api_version__is "2024.12"docs/index.md(lines 15-16) - Documentation still references 2024.12
If the intent is to test against 2025.12 while still implementing 2024.12, this should be documented. Otherwise, these files should be updated together to ensure the library declares support for the version it's being tested against.
|
CI failures are list/tuples in |
No description provided.