Skip to content

fix(spv): filter headers not starting from checkpoint on reconnect #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pauldelucia wants to merge 2 commits into from
Closed

fix(spv): filter headers not starting from checkpoint on reconnect #218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b163c5
fix: filters start from checkpoint on reconnect
pauldelucia Nov 27, 2025
050a5cd
doc: remove doc
pauldelucia Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dash-spv/src/storage/disk/filters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,15 @@ impl DiskStorageManager {
let mut next_blockchain_height = {
let current_tip = self.cached_filter_tip_height.read().await;
match *current_tip {
Some(tip) => tip + 1,
Some(tip) => {
// If we're syncing from a checkpoint and the current tip is below it,
// start from the checkpoint instead of continuing from the old tip
if sync_base_height > 0 && tip < sync_base_height {
sync_base_height
} else {
tip + 1
}
}
None => {
// If we have a checkpoint, start from there, otherwise from 0
if sync_base_height > 0 {
Expand Down