Skip to content

DAOS-18597 bio: allow SPDK reinitialization#17614

Merged
daltonbohning merged 2 commits intomasterfrom
janekmi/DAOS-18597-set-SPDK_RPC_STARTUP-manually
Mar 10, 2026
Merged

DAOS-18597 bio: allow SPDK reinitialization#17614
daltonbohning merged 2 commits intomasterfrom
janekmi/DAOS-18597-set-SPDK_RPC_STARTUP-manually

Conversation

@janekmi
Copy link
Contributor

@janekmi janekmi commented Feb 26, 2026 •
edited
Loading

Ref: spdk/spdk@fba209c
Ref: #16774

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@janekmi
DAOS-18597 bio: allow SPDK reinitialization
beb6239 
Ref: spdk/spdk@fba209c
Ref: #16774

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi requested review from a team as code owners February 26, 2026 16:57
@janekmi janekmi requested review from Nasf-Fan and NiuYawei and removed request for a team February 26, 2026 16:58
@github-actions
Copy link

github-actions bot commented Feb 26, 2026 •
edited
Loading

Ticket title is 'ddb dev_list with --vos_path in interactive mode causes segmentation fault'
Status is 'In Progress'
Labels: 'ddb,scrubbed_2.8,test_2.8'
https://daosio.atlassian.net/browse/DAOS-18597

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 26, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17614/1/testReport/

@janekmi
DAOS-18597 bio: underlaying ==> underlying
6b09d4f 
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Nasf-Fan
Nasf-Fan approved these changes Mar 2, 2026
View reviewed changes
src/bio/bio_xstream.c
* SPDK multiple times within the same process, for example when inspecting multiple pools
* sequentially. For those use cases, the RPC state must now be reset explicitly.
*/
spdk_rpc_set_state(SPDK_RPC_STARTUP);
Copy link
Contributor

@Nasf-Fan Nasf-Fan Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move it after init_arg allocation?

Copy link
Contributor Author

@janekmi janekmi Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose this location deliberately because:

  1. It is next to the spdk_subsystem_load_config() which called spdk_rpc_set_state() previously.
  2. But before anything related to init_arg so the preparation of the argument for the spdk_subsystem_load_config() remains undisturbed.

Copy link
Contributor

@NiuYawei NiuYawei Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks this change didn't solve the issue?

Copy link
Contributor Author

@janekmi janekmi Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solved the issue for me and for @knard38. 😁

I still work with @shimizukko to pin point why his case is different.

@janekmi janekmi requested a review from knard38 March 4, 2026 12:41
knard38
knard38 approved these changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have manually tested the proposed patch with success.

Image

@janekmi janekmi requested a review from a team March 5, 2026 11:34
@mchaarawi
Copy link
Contributor

mchaarawi commented Mar 6, 2026

remove gatekeeper till merge approval

@mchaarawi mchaarawi removed the request for review from a team March 6, 2026 15:19
@mchaarawi
Copy link
Contributor

mchaarawi commented Mar 6, 2026

@NiuYawei since you own most of bio, can you please review?

@janekmi janekmi requested a review from a team March 9, 2026 11:03
@daltonbohning daltonbohning removed the request for review from a team March 9, 2026 17:47
@janekmi janekmi requested a review from a team March 10, 2026 19:12
@daltonbohning daltonbohning merged commit c2f11e6 into master Mar 10, 2026
47 checks passed
@daltonbohning daltonbohning deleted the janekmi/DAOS-18597-set-SPDK_RPC_STARTUP-manually branch March 10, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@knard38 knard38 knard38 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@janekmi @daosbuild3 @mchaarawi @NiuYawei @Nasf-Fan @knard38 @daltonbohning