fix(interceptor): Capture.sh no longer passes --out to interceptor screenshot - #2106
Open
pai-scaffolde wants to merge 1 commit into
Open
fix(interceptor): Capture.sh no longer passes --out to interceptor screenshot#2106pai-scaffolde wants to merge 1 commit into
interceptor screenshot#2106pai-scaffolde wants to merge 1 commit into
Conversation
…creenshot`
The stock interceptor CLI rejects `--out` on `screenshot` ("unknown flag
'--out' for 'screenshot' (--out belongs to 'save' and 'net'; 'screenshot
--save' writes the image to disk)"), so both the DOM path and the --pixel
fallback failed and the wrapper exhausted recovery with exit 9 on every
call. The flag only ever worked against the maintainer's cherry-picked
binary (SKILL.md "Pinned binary" note).
`--save` writes into the CLI's cwd and reports the file as "filePath".
Run each capture from $OUT's directory and let the existing resolve_saved()
move the reported file onto $OUT — the reconciliation the --pixel path
already relied on. SKILL.md's stock-install sentence now says that instead
of "pass --out explicitly".
Public issue danielmiessler#2065.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced on a fresh LifeOS 7.40.4 install (macOS, Claude Code in the Claude desktop app, stock interceptor 0.24.13); the fix was applied to that install and
Capture.shrun end to end there before filing. Fixes #2065.Observed
Every capture — DOM path,
--pixelfallback, and the recovery loop — failed the same way, so the skill's mandatory browser verification could not produce one screenshot.Root cause
Capture.sh:189buildsSS_FLAGS=(--context "$CTX" --save --out "$OUT"). Upstreaminterceptor screenshothas no--out; the flag belongs tosaveandnet. The wrapper was written against the maintainer's cherry-picked binary (SKILL.md "Pinned binary" note), which SKILL.md itself says does not describe public installs. On a stock binary--savewrites into the CLI's cwd and reports the file asfilePath— whichresolve_saved()already lifts into$OUTfor the--pixelpath.Fix
Drop
--outfromSS_FLAGS; run bothdom_captureandpixel_capturein a subshellcd'd to$OUT's directory so--savelands there; the existingresolve_saved()moves the reportedfilePathonto$OUT.--fullis still accepted by the CLI (it gets past flag parsing to the context lookup). SKILL.md's stock-install sentence now says this instead of "pass--outexplicitly".How tested
bash -n Capture.shclean.interceptor screenshot --context zz-bogus --save --out /tmp/x.png→error: unknown flag '--out' for 'screenshot'(rejected before any daemon contact);... --save --fulland... --save→ reach the context lookup.Capture.sh https://example.comprints the saved path and exits 0; the--saveresult carriesfilePathasresolve_saved()expects.🤖 Generated with Claude Code