Repository navigation
src/canonicalize.rs: apply clippy fixes with two places - #850
Conversation
Signed-off-by: Attila Hammer <hammera@pickup.hu>
Linux library size: 0.58 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
|
Very nice, all online checks are passed. Attila |
you can click on the box where it says "all checks have passed". There it lists the runtime of each check. It is dominated by the fuzzing test that Neil has created a while ago, which takes 122 minutes. The other checks are all just a few minutes. Next time I talk to Neil, I will ask him about it, as I also don't exactly know the context around the fuzzing tests. |
|
ok, looks good. The clippy change is here for completeness of documentation: https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#nonstandard_macro_braces I wasn't aware that there is ambiguous syntax for macros like this, but I agree that we should then just fix it accordingly. I'm surprised though that this then is the only place we need to clean up. I again checked the error description in your failed job and it only complains about these two lines. |
Hi,
@moritz-gross, I applyed two simple clippy fixes after rustup update command build, because after my fork syncing to the upstream main branch, I get a notification failure e-mail with clippy fixes related.
So, I update my rust environment with rustup to the latest stable version, applyed clippy fixes with the proper cargo clippy related option, commit and push the changes.
After this commit, my fork the build pipeline is ran successfull.
If all checks result good too in upstream Github online workflows, and anybody reviewing this simple change, if need please merge this change to the upstream Mathcat repo main branch.
Now I use following Rust version my Debian 12 machine:
rustc 1.99.0 (b940084d7 2026-09-28)
Of course the cargo build, cargo test commands ran successful my local machine, I looked this commands results before pushing my fork main branch.
Attila