Conversation
cyphar
added
api/cffi
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cyphar
force-pushed
the
flags-u64
branch
5 times, most recently
from
2c265c5 to
74a84c2
Compare
CString::into_raw will leak memory, we should use CStr::as_ptr but bind to a local variable. This is "only" test code but it would be nice to avoid leaking memory like this. Fixes: cfb756c ("capi: change *link arguments to match syscall API") Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
Recently it seems that OPENAT2_* flags will start taking up bits of the higher 32-bits available with openat2(2) and so we will need to be able to represent them. Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
Now that OpenFlags is a u64 we can directly embed it into OpenHow and remove all of the "as u64" casts we had for this case. Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently it seems that
OPENAT2_*flags will start taking up bits of thehigher 32-bits available with
openat2(2)and so we will need to be ableto represent them.
Signed-off-by: Aleksa Sarai aleksa@amutable.com