Open
Conversation
Convert all tabs to 4 spaces for subroutine _validate_args. Remove trailing whitespace and canonicalize things according to Perl Best Practices. This is in anticipation of further changes coming.
Setting this to true will give the web user an underscore "override" checkbox when creating a record within a domain.
Use extra_argv to pass UI checkbox value to this function to determine if underscore validation needs to occur.
Pass "allow_underscore_override" value into _validate_args.
If configuration values are set appropriately then return a string and checkbox for overriding underscore validation.
Potentially alter form with underscore validation override checkbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add one or two RR's to a domain, but I don't want to toggle the config option:
ALLOW_UNDERSCORES_IN_DEVICE_NAMES
Instead, I've added a new config option:
UNDERSCORES_IN_DEVICE_NAMES_OVERRIDE_ALLOWED
that if set will display a checkbox on host.html when adding a record from management/zone_tasks.html. Checking the checkbox will allow that record to contain underscores.