-
Notifications
You must be signed in to change notification settings - Fork 18
fix: sync discovery schema/spec with IETF-RFC.md #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
64909db
fix: sync discovery schema/spec with IETF-RFC.md
MahdiBaghbani 6282588
rtemove: spec.json, this would be another pr later
MahdiBaghbani 615192e
fix: linter max size
MahdiBaghbani e93de04
fix(discovery): revert to JSON, use jwks, add diagram ref
MahdiBaghbani 4802dd5
Merge branch 'develop' into mahdi/fix/inconsistencies
MahdiBaghbani 4ce1af8
docs: mention the single source of truth in diagrams
MahdiBaghbani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| { | ||
| // Discovery schema for OCM API Discovery (JSON Schema, JSONC for comments). | ||
|
MahdiBaghbani marked this conversation as resolved.
Outdated
|
||
| // | ||
| // Content source of truth: IETF-RFC.md (this repo). | ||
| // | ||
| // Mixed URL forms (per draft wording): | ||
| // - inviteAcceptDialog is a URL path (starts with "/"), resolved at the server origin. | ||
| // - tokenEndPoint is a URL (typically https://...) of the token exchange endpoint. | ||
| // | ||
| "title": "OCM API Discovery", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "type": "object", | ||
| "properties": { | ||
| "enabled": { "type": "boolean" }, | ||
| "apiVersion": { "type": "string" }, | ||
| "endPoint": { "type": "string", "format": "uri" }, | ||
| "provider": { "type": "string" }, | ||
| "resourceTypes": { | ||
| "type": "array", | ||
| "items": { "$ref": "#/$defs/resourceType" } | ||
| }, | ||
| "capabilities": { | ||
| "type": "array", | ||
| "description": "Optional capability tokens (for example: enforce-mfa, exchange-token, http-sig, invites, invite-wayf, notifications, protocol-object, webdav-uri).", | ||
| "items": { "type": "string" } | ||
| }, | ||
| "criteria": { | ||
| "type": "array", | ||
| "description": "Optional criteria tokens (for example: http-request-signatures, token-exchange, denylist, allowlist, invite).", | ||
| "items": { "type": "string" } | ||
| }, | ||
| "publicKey": { "$ref": "#/$defs/publicKeyLegacy" }, | ||
| "publicKeys": { | ||
| "type": "array", | ||
| "description": "Optional public keys for RFC 9421 HTTP Message Signatures (see IETF-RFC.md).", | ||
| "items": { "$ref": "#/$defs/publicKeyRfc9421" } | ||
| }, | ||
| "inviteAcceptDialog": { | ||
| "type": "string", | ||
| "pattern": "^/", | ||
| "description": "URL path of a web page where a user can accept an invite (see IETF-RFC.md)." | ||
| }, | ||
| "tokenEndPoint": { | ||
| "type": "string", | ||
| "format": "uri", | ||
| "pattern": "^https?://", | ||
| "description": "URL of the token exchange endpoint (see IETF-RFC.md)." | ||
| } | ||
| }, | ||
| "required": ["enabled", "apiVersion", "endPoint", "resourceTypes"], | ||
| "$defs": { | ||
| "resourceType": { | ||
| "properties": { | ||
| "name": { "type": "string" }, | ||
| "shareTypes": { "type": "array" }, | ||
| "protocols": { "$ref": "#/$defs/protocols" } | ||
| }, | ||
| "required": ["name", "shareTypes", "protocols"] | ||
| }, | ||
| "protocols": { | ||
| "type": "object", | ||
| "minProperties": 1, | ||
| "description": "Additional protocols besides 'webdav', 'webapp' and 'ssh' may be defined.", | ||
| "properties": { | ||
| "webdav": { "type": "string", "pattern": "^/" }, | ||
| "webapp": { "type": "string", "pattern": "^/" }, | ||
| "ssh": { "type": "string" } | ||
| } | ||
| }, | ||
| "publicKeyLegacy": { | ||
| "type": "object", | ||
| "properties": { | ||
| "keyId": { "type": "string" }, | ||
| "publicKeyPem": { "type": "string" } | ||
| }, | ||
| "required": ["keyId", "publicKeyPem"] | ||
| }, | ||
| "publicKeyRfc9421": { | ||
| "type": "object", | ||
| "properties": { | ||
| "keyId": { "type": "string" }, | ||
| "publicKeyPem": { "type": "string" }, | ||
| "algorithm": { "type": "string" } | ||
| }, | ||
| "required": ["keyId", "publicKeyPem", "algorithm"] | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.