Add ollama_api_key support for remote Ollama endpoints#612
Conversation
Superseded due to shell-escaped formatting corruption in review body.
crmne
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I’m requesting changes because the repository contribution requirements for new features are not met yet:
- New features require a prior approved issue, and this PR has no linked issue (
closingIssuesReferencesis empty and the PR checklist leaves that unchecked). - The quality checklist indicates
overcommithooks were not run. Please run the configured hooks and update the checklist. - This introduces
ollama_api_keysupport, but there is no accompanying docs update (for example, indocs/_getting_started/configuration.md), and the PR checklist leaves documentation unchecked.
Please address these process requirements and re-request review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 80.13% 80.14%
=======================================
Files 113 113
Lines 5095 5096 +1
Branches 1307 1308 +1
=======================================
+ Hits 4083 4084 +1
Misses 1012 1012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will do. Thanks |
|
Thanks for following up. I’ll take care of the small remaining docs/process bits on this PR so we can merge quickly. For your next feature PR, please include the linked pre-approved issue and docs updates in the initial submission. |
What this does
Allow callinc remote Ollama endpoints for using ollama cloud models
Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code