Fix streaming tool call nil arguments#587
Merged
crmne merged 5 commits intocrmne:mainfrom Mar 1, 2026
Merged
Conversation
|
Faced exactly the same issue with openrouter provider |
|
I had been running into issues using Haiku 4.5 at AWS Bedrock while streaming and using tool calls. The way it manifested was the model calling a tool with incorrect parameters. I always had a sneaking suspicion that it wasn't model hallucination because I had never experienced that when I was using the AWS SDK directly instead of RubyLLM. I just applied this patch to my system and my sreaming issues with Haiku seen to have been resolved. this would be great to get merged into core. |
Contributor
Author
|
Thanks for confirming and for testing this. |
|
Is this error I've just started seeing on local/Ollama related to this PR? I wasn't seeing this about a month ago, maybe a recent Ollama update changed something? If not related, shall I open a new issue? |
Owner
|
Hi @KieranP could you root cause that error to this PR? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 80.85% 80.87% +0.01%
==========================================
Files 113 113
Lines 5177 5181 +4
Branches 1340 1342 +2
==========================================
+ Hits 4186 4190 +4
Misses 991 991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@KieranP thanks for reporting this. I traced it and it looks separate from #587: this PR fixes |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes a streaming crash when tool-call deltas omit
function.argumentsby normalizing nil/empty fragments during accumulation, and adds a regression spec to cover the case.Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes