5.11

CHANGELOG-5.11.md

@@ -0,0 +1,24 @@
+# Release Notes for Craft CMS 5.11 (WIP)
+
+### Content Management
+- Asset alt text no longer gets propagated to all sites the first time it’s filled in. ([#19067](https://github.com/craftcms/cms/pull/19067)) 
+
+### Development
+- The `params` argument of the `url()` Twig function now accepts `false` to remove all params from the passed-in URL. ([#19102](https://github.com/craftcms/cms/pull/19102))
+- Added `craft\web\DbSession`, which should be used instead of `yii\web\DbSession` to prevent “headers already sent” warnings from getting logged. ([#19139](https://github.com/craftcms/cms/issues/19139))
+- Arrays created from `craft\fields\data\LinkData` objects now include `type`, `value`, `url`, `label`, `filename`, `link`, `attributes`, `defaultLabel`, `elementType`, `elementId`, `elementSiteId`, and `elementTitle` keys. ([craftcms/element-api#201](https://github.com/craftcms/element-api/issues/201)) 
+
+### Extensibility
+- Added `craft\helpers\UrlHelper::removeAllParams()`. ([#19102](https://github.com/craftcms/cms/pull/19102))
+- Added `craft\helpers\UrlHelper::removeParams()`. ([#19102](https://github.com/craftcms/cms/pull/19102))
+- Added `craft\services\Elements::reorderNestedElements()`. ([#19321](https://github.com/craftcms/cms/issues/19321))
+- The `$params` argument of `craft\helpers\UrlHelper::url()` now accepts `false` to remove all params from the passed-in URL. ([#19102](https://github.com/craftcms/cms/pull/19102))
+
+### System
+- Added support for `.well-known/passkey-endpoints` requests. ([#19364](https://github.com/craftcms/cms/pull/19364))
+- The front-end login page no longer returns a redirect response for logged-in users, if it’s a preview request. ([#19360](https://github.com/craftcms/cms/discussions/19360))
+- Improved queue job reservation performance when queues contain many large jobs. ([#19097](https://github.com/craftcms/cms/issues/19097))
+- Updated Twig to 3.28.
+- Updated yii2-debug to 2.1.28.
+- Fixed an error that could occur when editing an element. ([#17268](https://github.com/craftcms/cms/issues/17268))
+- Fixed a bug where `getEagerLoadedElements()` wasn’t returning results for eager-loaded native fields, such as `authors`. ([#19471](https://github.com/craftcms/cms/pull/19471))

composer.json

@@ -68,11 +68,11 @@
     "symfony/var-dumper": "^5.0|^6.0|^7.0",
     "symfony/yaml": "^5.2.3|^6.0|^7.0",
     "theiconic/name-parser": "^1.2",
-    "twig/twig": "~3.27.0",
+    "twig/twig": "~3.28.0",
     "voku/portable-ascii": "^2.0",
     "web-auth/webauthn-lib": "~5.3.5",
     "yiisoft/yii2": "~2.0.55.0",
-    "yiisoft/yii2-debug": "~2.1.27.0",
+    "yiisoft/yii2-debug": "~2.1.28.0",
     "yiisoft/yii2-queue": "~2.3.2",
     "yiisoft/yii2-symfonymailer": "^4.0.0"
   },

src/base/NestedElementTrait.php

@@ -434,9 +434,9 @@ public function setEagerLoadedElements(string $handle, array $elements, EagerLoa
             case 'primaryOwner':
                 $this->setPrimaryOwner(reset($elements) ?: null);
                 break;
-            default:
-                parent::setEagerLoadedElements($handle, $elements, $plan);
         }
+
+        parent::setEagerLoadedElements($handle, $elements, $plan);
     }
 
     /**

src/config/app.php

@@ -4,7 +4,7 @@
     'id' => 'CraftCMS',
     'name' => 'Craft CMS',
     'version' => '5.10.14',
-    'schemaVersion' => '5.10.0.0',
+    'schemaVersion' => '5.11.0.2',
     'minVersionRequired' => '4.5.0',
     'basePath' => dirname(__DIR__), // Defines the @app alias
     'runtimePath' => '@storage/runtime', // Defines the @runtime alias

src/controllers/NestedElementsController.php

@@ -9,7 +9,6 @@
 
 use Craft;
 use craft\base\ElementInterface;
-use craft\base\NestedElementInterface;
 use craft\db\Table;
 use craft\elements\db\ElementQueryInterface;
 use craft\elements\ElementCollection;
@@ -82,38 +81,7 @@ public function actionReorder(): Response
         $ids = array_map(fn($id) => (int)$id, $this->request->getRequiredBodyParam('elementIds'));
         $offset = $this->request->getRequiredBodyParam('offset');
 
-        if ($this->nestedElements instanceof ElementQueryInterface) {
-            $oldSortOrders = (clone $this->nestedElements)
-                ->status(null)
-                ->asArray()
-                ->select(['id', 'sortOrder'])
-                ->pairs();
-        } else {
-            $oldSortOrders = $this->nestedElements
-                ->keyBy(fn(ElementInterface $element) => $element->id)
-                /** @phpstan-ignore-next-line */
-                ->map(fn(NestedElementInterface $element) => $element->getSortOrder())
-                ->all();
-        }
-
-        // Build the full list of IDs in the new sort order
-        $allIds = array_diff(array_keys($oldSortOrders), $ids);
-        array_splice($allIds, $offset, 0, $ids);
-
-        // Update all the incorrect sort orders
-        foreach ($allIds as $i => $id) {
-            $sortOrder = $i + 1;
-            if (!isset($oldSortOrders[$id]) || $sortOrder !== $oldSortOrders[$id]) {
-                Db::update(Table::ELEMENTS_OWNERS, [
-                    'sortOrder' => $sortOrder,
-                ], [
-                    'ownerId' => $this->owner->id,
-                    'elementId' => $id,
-                ]);
-            }
-        }
-
-        Craft::$app->getElements()->invalidateCachesForElement($this->owner);
+        Craft::$app->getElements()->reorderNestedElements($this->owner, $this->nestedElements, $ids, $offset);
 
         return $this->asSuccess(Craft::t('app', 'New {total, plural, =1{position} other{positions}} saved.', [
             'total' => count($ids),

src/controllers/UsersController.php

@@ -233,10 +233,13 @@ public function actionLogin(): ?Response
         }
 
         if ($this->request->getIsGet()) {
-            // see if they're already logged in
-            $user = static::currentUser();
-            if ($user) {
-                return $this->_handleSuccessfulLogin($user);
+            // see if they're already logged in, unless this is a preview request
+            // (see https://github.com/craftcms/cms/discussions/19360)
+            if (!$this->request->getIsPreview()) {
+                $user = static::currentUser();
+                if ($user) {
+                    return $this->_handleSuccessfulLogin($user);
+                }
             }
 
             // should we be showing the 2FA form?

src/controllers/WellKnownController.php

@@ -0,0 +1,30 @@
+<?php
+/**
+ * @link https://craftcms.com/
+ * @copyright Copyright (c) Pixel & Tonic, Inc.
+ * @license https://craftcms.github.io/license/
+ */
+
+namespace craft\controllers;
+
+use craft\web\Controller;
+use yii\web\Response;
+
+/**
+ * Class WellKnownController
+ *
+ * @author Pixel & Tonic, Inc. <support@pixelandtonic.com>
+ * @since 5.11.0
+ */
+class WellKnownController extends Controller
+{
+    protected array|bool|int $allowAnonymous = self::ALLOW_ANONYMOUS_LIVE;
+
+    public function actionPasskeyEndpoints(): Response
+    {
+        // Just return an empty object to signal support for passkeys, w/o leaking the CP URL.
+        $this->response->format = Response::FORMAT_JSON;
+        $this->response->content = '{}';
+        return $this->response;
+    }
+}