Fix #15021 FN redundantInitialization with structured binding - #8847
chrchr-github wants to merge 3 commits into
Conversation
chrchr-github
added
the
merge-after-next-release
chrchr-github
removed
the
merge-after-next-release
| std::vector<const Token*> tokensToCheck{ tok->astOperand1() }; | ||
| if (Token::simpleMatch(tok->astOperand1(), "[") && Token::simpleMatch(tok->astOperand1()->astOperand1(), "auto")) // structured binding | ||
| tokensToCheck = astFlatten(tok->astOperand1()->astOperand2(), ","); |
There was a problem hiding this comment.
This is an AI review. Take it with a grain of salt and feel free to reject it by resolving the comment.
Looks good to me. I built it and checked that reference bindings don't produce false positives: auto& [x, y] = s; x = 1;, auto&& [x, y] = std::move(s);, for (auto& [k, v] : m) v = 0; and auto& [x, y] = arr; all stay silent. auto [x, y] = p; with a std::pair is reported.
Question: the ticket and the PR title say "FN redundantInitialization", but since isInitialization is only set for split ; %var% = declarations, the structured binding is reported as redundantAssignment ("is reassigned a value before the old one has been used", with notes "x is assigned" / "x is overwritten"). Semantically auto [x, y] = s; is an initialization. Should isInitialization be set for the structured binding case so that redundantInitialization is reported, including the existing "trivial rhs" handling? If redundantAssignment is intended, maybe adjust the title so the history matches.
2 participants
Best viewed with whitespace changes hidden.