Repository navigation
Conversation
Previously an SSO signup would redirect to /me/preferences, which would lead to a 404 on non-public databases. Now it only redirects if email preferences are set (unlikely for institutional SSO)
oliche
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSO-only signups for a non-public database were already fully supported: here I just added tests, ensured staff status was True by default, and made the signup redirect depend on whether email preferences are configured (for a lab database they probably wouldn't be).
As a bonus I added support for generic OIDC logins, which have extra settings (namely a provider id). This allows for practically any SSO*. I changed the documented example to Shibboleth.
*The settings differ further for pure SAML (
organization_sluginstead ofprovider_id), which I didn't bother to add support for.