[codex] fix(prompt): unify serial tool-calling instructions#12089
[codex] fix(prompt): unify serial tool-calling instructions#12089yzlu0917 wants to merge 1 commit intocontinuedev:mainfrom
Conversation
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/vscode/src/util/runCommandInTerminal.ts">
<violation number="1" location="extensions/vscode/src/util/runCommandInTerminal.ts:71">
P1: Remote terminal creation can resolve to an unrelated newly opened terminal, causing command execution in the wrong terminal session.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
|
|
||
| settled = true; | ||
| cleanup(); | ||
| resolve(terminal); |
There was a problem hiding this comment.
P1: Remote terminal creation can resolve to an unrelated newly opened terminal, causing command execution in the wrong terminal session.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/vscode/src/util/runCommandInTerminal.ts, line 71:
<comment>Remote terminal creation can resolve to an unrelated newly opened terminal, causing command execution in the wrong terminal session.</comment>
<file context>
@@ -0,0 +1,118 @@
+
+ settled = true;
+ cleanup();
+ resolve(terminal);
+ });
+
</file context>
💡 Codex ReviewLines 42 to 44 in 6daeaa4 This workspace filter only runs inside ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6daeaa4 to
3420498
Compare
3420498 to
2cbd793
Compare
Summary
Why
Continue currently gives models conflicting instructions about tool sequencing. The base agent system message says multiple read-only tools can be called simultaneously, while the system-message tool framework says only one tool can be called at a time. In practice, Continue already defaults to serial tool execution and disables parallel tool calls for OpenAI-compatible requests in the common path, so the prompt should match reality.
This removes the contradiction and makes the default guidance consistent: call one tool, wait for the result, then decide the next step.
Validation
npm test -- src/redux/util/getBaseSystemMessage.test.tsinguinpm run vitest -- tools/systemMessageTools/toolCodeblocks/buildSystemMessage.vitest.tsincoregit diff --checkCloses #9308
Summary by cubic
Unifies tool-calling guidance to a single serial policy so prompts match actual behavior. Aligns with #9308 and standardizes OpenRouter headers.
coreandguito assert serial instruction and absence of “simultaneously”.OPENROUTER_HEADERSfrom@continuedev/openai-adaptersincore/llm/llms/OpenRouter; export headers and update keys toX-OpenRouter-TitleandX-OpenRouter-Categories.Written for commit 2cbd793. Summary will update on new commits.