Open
Conversation
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/user-attachments/assets/a77c6b8e-3eca-4a12-8db8-500804b36d56
Thread
Issue Summary
Even when
PURGE_PREVIEW_SDK=true, the full Live Preview SDK is still getting bundled and executed.Why this is happening
In the current code:
Both
LightLivePreviewHoCandContentstackLivePreviewHOCare statically imported in the main entry.Because of this, the bundler still includes:
•
ContentstackLivePreviewHOC(full SDK)• Live Preview logic
• Edit button (
#cslp-tooltip)• Visual Builder code
•
effect()logic that injects the buttonWhat DefinePlugin / env var actually does
PURGE_PREVIEW_SDK=trueonly changes which export is returned at runtime.It does not stop the full SDK module graph from being bundled, because the import itself is static.
Result
•
LightLivePreviewHoCis indeed the exported default at runtime ✅• But the full SDK is still loaded and executed as a side effect ❌
• This is why the customer still sees
#cslp-tooltipand Visual Builder code in the bundle and DOM.Conclusion
Setting
PURGE_PREVIEW_SDK=truealone does not remove the full SDK from the bundle.It only switches the exported HOC; it does not prevent the full Live Preview code from being imported and executed.