tests: fix race condition in TestRunWithSystemdTrueEnabled#4721
Merged
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom Jan 30, 2026
Merged
tests: fix race condition in TestRunWithSystemdTrueEnabled#4721ChengyuZhu6 merged 1 commit intocontainerd:mainfrom
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom
Conversation
haytok
approved these changes
Jan 27, 2026
Member
haytok
left a comment
haytok
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix.
Since TestRunWithSystemdTrueEnabled passes in this PR, let's see if the situation improves.
AkihiroSuda
reviewed
Jan 29, 2026
|
|
||
| testCase.SubTests = []*test.Case{ | ||
| { | ||
| Description: "should expose SIGTERM+3 stop signal labels", |
Member
There was a problem hiding this comment.
The description texts should not be removed.
At least it should remain as code comments.
AkihiroSuda
reviewed
Jan 29, 2026
| Expected: test.Expects(expect.ExitCodeSuccess, nil, expect.Contains("SIGRTMIN+3")), | ||
| }, | ||
| { | ||
| Description: "waits for systemd to become ready and lists systemd jobs", |
consolidate subtests into sequential commands to prevent runc exec conflicts. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consolidate subtests into sequential commands to prevent runc exec conflicts.
e.g.:
https://github.com/containerd/nerdctl/actions/runs/21329667209/job/61471351107?pr=4719