Expose Ability to Get the Number Of a List Item#600
Open
bfoersterling wants to merge 1 commit intocommonmark:masterfrom
Open
Expose Ability to Get the Number Of a List Item#600bfoersterling wants to merge 1 commit intocommonmark:masterfrom
bfoersterling wants to merge 1 commit intocommonmark:masterfrom
Conversation
- add cmark_node_get_item_number() function - store item number in cmark_item member Signed-off-by: Bjoern Foersterling <bjoern.foersterling@gmail.com>
Member
|
@nwellnhof any objections to this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rationale
The function
cmark_node_get_item_number()improves the user friendlinessof the API as the library user does not have to implement a logic to derive
the number of a list item.
It is more efficient to store the item number once when parsing the markdown
content.
The function
cmark_node_get_item_numberonly has to look at the previousnode. The library user might need to traverse until the start of the list
if he does not want to store the item numbers in a separate data type.
implementation
I added the new type
cmark_itemand made it a union member for theasmember in
cmark_node.The item number is calculated and stored in the function
finalize().