Skip to content

Rollback eslint update#915

Merged
CarlosCortizasCT merged 1 commit intomainfrom
cm/rollback-eslint-update
Jul 7, 2025
Merged

Rollback eslint update#915
CarlosCortizasCT merged 1 commit intomainfrom
cm/rollback-eslint-update

Conversation

@CarlosCortizasCT
Copy link
Copy Markdown
Contributor

@CarlosCortizasCT CarlosCortizasCT commented Jul 7, 2025 •
edited
Loading

Description

The eslint major update is breaking the lintin script in the repository so we want to roll it back and look at it again more closely.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: 19691de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarlosCortizasCT CarlosCortizasCT self-assigned this Jul 7, 2025
@CarlosCortizasCT CarlosCortizasCT marked this pull request as ready for review July 7, 2025 14:26
Sarah4VT
Sarah4VT requested changes Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Sarah4VT Sarah4VT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this. It was a local issue. Can close.

@CarlosCortizasCT
Copy link
Copy Markdown
Contributor Author

CarlosCortizasCT commented Jul 7, 2025

Don't need this. It was a local issue. Can close.

This is actually needed. The lint script is failing on main because of this dependency update.

Sarah4VT
Sarah4VT approved these changes Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Sarah4VT Sarah4VT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot I had this running locally when I fixed my local issue.

@CarlosCortizasCT CarlosCortizasCT merged commit a68360f into main Jul 7, 2025
4 checks passed
@CarlosCortizasCT CarlosCortizasCT deleted the cm/rollback-eslint-update branch July 7, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdeekens tdeekens tdeekens approved these changes

@Sarah4VT Sarah4VT Sarah4VT approved these changes

@Ibidapo Ibidapo Awaiting requested review from Ibidapo

Assignees

@CarlosCortizasCT CarlosCortizasCT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlosCortizasCT @tdeekens @Sarah4VT