Skip to content

chore: pin coder dependency to an immutable commit SHA - #1053

Open
EhabY wants to merge 1 commit into
mainfrom
chore/pin-coder-dep
Open

chore: pin coder dependency to an immutable commit SHA#1053
EhabY wants to merge 1 commit into
mainfrom
chore/pin-coder-dep

Conversation

@EhabY

@EhabY EhabY commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Review priority: 3/10. One-minute review: immutability pin, resolution unchanged.
Diff: manifest/lockfile +3/-2, no production or test code

Pins the coder git dependency to the commit SHA that v2.34.1 points at, instead of the tag name.

Git tags are mutable and git-hosted dependencies are the one class of lockfile entry with no integrity: hash to catch a re-pointed ref. The lockfile already resolves to this exact commit (2e8d80a, verified to be the tag's target via the GitHub API), so resolution is byte-identical; this makes the manifest itself immutable too. The comment keeps the human-readable version mapping.

Alternatives considered

  • Consume the needed types/helpers from a published npm package. Pro: integrity hashes and normal release review. Con: requires upstream packaging work; not available today.
  • Vendor the small amount of imported code. Pro: no external fetch at all. Con: manual sync burden on every coder/coder bump; easy to fall behind.
  • SHA pin (chosen): immutable with zero workflow change. Con: bumps must update SHA and comment together, verifying the SHA against the release tag.

Tags can be re-pointed upstream; the commit SHA (v2.34.1's target,
verified via the GitHub API) cannot. Resolution is unchanged - the
lockfile already resolved to this exact commit.
@EhabY
EhabY force-pushed the chore/pin-coder-dep branch from 90766ad to d6abbc8 Compare July 30, 2026 08:36
@EhabY
EhabY requested a review from jdomeracki-coder July 30, 2026 08:48
@EhabY EhabY self-assigned this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant