fix: auto-bracket bare IPv6 literals in serpent.URL.Set#33
Draft
rowansmithau wants to merge 1 commit into
Draft
Conversation
net/url.Parse cannot disambiguate an unbracketed IPv6 host from its trailing port (e.g. "http://2600:2222::22:8080" fails with "invalid port ... after host"). This breaks CODER_DERP_SERVER_RELAY_URL when set from a Kubernetes IPv6 pod IP (coder/coder#27266). Detect this shape in the authority component and wrap the IPv6 literal in brackets before delegating to url.Parse. IPv4 hosts, hostnames, and already-bracketed IPv6 hosts are left untouched, so this is a strict superset of previously-accepted input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to solve 27266 in coder/coder.
net/url.Parse cannot disambiguate an unbracketed IPv6 host from its trailing port (e.g. "http://2600:2222::22:8080" fails with "invalid port ... after host"). This breaks CODER_DERP_SERVER_RELAY_URL when set from a Kubernetes IPv6 pod IP.
This adds detection of IPv6 address add brackets them accordingly.
Tested on a local build of coder with a replace directive.
I ran
go mod edit -replace github.com/coder/serpent=github.com/coder/serpent@rowan/serpent_ipv6_auto_bracket && go mod tidyfollowed bymake teston coder's main branch and those tests still passed.