🤖 feat: add stable/nightly Electron update channels by ibetitsmike · Pull Request #2430 · coder/mux

ibetitsmike · 2026-02-14T20:45:02Z

Summary

Adds a user-selectable update channel (Stable / Nightly) to the Mux Electron app. Users can switch channels from the About dialog; the choice is persisted in ~/.mux/config.json and takes effect immediately at runtime.

Background

The Electron app currently updates only from official GitHub Releases ("Stable"). This PR adds support for a "Nightly" channel that pulls pre-release builds published from main. This gives users who want bleeding-edge features an opt-in path without disrupting the default stable experience.

Implementation

Config layer (`src/node/config.ts`)

New UpdateChannel type ("stable" | "nightly") with parseUpdateChannel() validation.
Persisted in config.json — only non-default values are written (stable is the default, so the key is omitted when on stable).

Desktop updater (`src/desktop/updater.ts`)

applyChannel() configures autoUpdater: allowPrerelease, channel, feed URL releaseType.
setChannel() method with state guards (blocks switching during download/install).
Transient error filtering (404s, network timeouts) to avoid noisy errors during manifest propagation.

oRPC surface (`src/common/orpc/schemas/api.ts`, `src/node/orpc/router.ts`)

update.getChannel / update.setChannel endpoints with Zod-validated UpdateChannelSchema.

Frontend (`src/browser/components/About/AboutDialog.tsx`)

Channel picker using standard ToggleGroup segmented control (size="sm", matching other consumers).
Race condition protection via channelRequestTokenRef counter.
Channel state initialized to null until fetched, preventing layout flicker.
Local pendingAction state gives immediate click feedback (spinner + disabled) for Check, Download, and Install buttons while waiting for the backend status stream to catch up.

Button press feedback (`src/browser/components/ui/button.tsx`)

Added active:scale-[0.98] press animation and transition-all so all buttons give tactile click feedback.

CI: manifest naming (`scripts/set-package-version.js`)

Detects prerelease suffix (e.g. -nightly.N) and sets build.publish.channel in package.json so electron-builder generates channel-specific manifests (nightly.yml, nightly-mac.yml) instead of latest.yml.

Validation

All static checks pass locally (make static-check: typecheck, lint, fmt, broken links).
Updater test suite (src/desktop/updater.test.ts) covers channel switching, state guards, and transient error handling.

Risks

macOS code signing: The manifest naming fix (set-package-version.js) ensures electron-updater finds the correct nightly-mac.yml manifest. Previously, the build produced latest-mac.yml which caused signature validation failures when the client expected nightly-mac.yml.

Generated with mux • Model: anthropic:claude-opus-4-6 • Thinking: xhigh • Cost: $26.04

…icker

When the version string includes a prerelease suffix like '-nightly.N', set build.publish.channel in package.json so electron-builder generates channel-specific manifests (e.g. nightly.yml, nightly-mac.yml) instead of the default latest.yml. This is required for electron-updater to resolve the correct manifest when autoUpdater.channel is set to 'nightly'.

Remove custom border/rounded-none overrides that clashed with the component's built-in segmented control appearance. Use the standard size='sm' variant which matches other ToggleGroup consumers (e.g. SecretsModal, SecretsSection).

ibetitsmike · 2026-02-20T12:58:19Z

@codex review

chatgpt-codex-connector · 2026-02-20T13:04:56Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…tons

ibetitsmike · 2026-02-20T13:54:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c7bca4f4e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/desktop/updater.ts

ibetitsmike · 2026-02-20T14:12:32Z

@codex review

Addressed P2 feedback: replaced hardcoded owner: "coder", repo: "mux" in applyChannel() with getGitHubRepo() helper that derives owner/repo from package.json's repository.url field (with fallback).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9dcb939a7c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/desktop/updater.ts

ibetitsmike · 2026-02-20T14:20:52Z

@codex review

Fixed the regex in getGitHubRepo() to handle dots in repo names (e.g. mux.desktop): changed ([^/.]+) to ([^/]+?)(?:\.git)?$ which captures the full repo name and strips the .git suffix via a non-capturing group.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0cb920f24

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/components/About/AboutDialog.tsx

ibetitsmike · 2026-02-20T14:27:29Z

@codex review

Fixed: all three action handlers now use .catch(console.error).finally(() => setPendingAction(...)) to clear the pending spinner even when the backend no-ops (e.g. clicking "Check" while already in downloaded state). The .finally() callback only clears if pendingAction still matches the action that set it, avoiding race conditions with other user actions.

chatgpt-codex-connector · 2026-02-20T14:33:47Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ibetitsmike changed the title ~~🤖 feat: add stable/latest Electron update channels~~ 🤖 feat: add stable/nightly Electron update channels Feb 15, 2026

ibetitsmike force-pushed the mike/stable-latest-update-channels branch 2 times, most recently from 78b1466 to 1db6499 Compare February 18, 2026 08:58

ibetitsmike added 8 commits February 20, 2026 12:12

feat: add update channel config support

4984756

feat: add updater channel switching

f92f045

feat: expose update channel via update service and orpc

ffa6302

feat: add update channel picker to About dialog

9bbfa88

fix: resolve lint errors in storybook mocks and updater tests

7c74345

fix update channel switch guards and persistence ordering

17bdb55

fix: improve channel picker accessibility, prevent stale state and fl…

1b2ac3c

…icker

refactor: rename update channel "latest" → "nightly"

15a6196

ibetitsmike force-pushed the mike/stable-latest-update-channels branch from 1db6499 to 15a6196 Compare February 20, 2026 12:12

ibetitsmike added 2 commits February 20, 2026 12:55

fix: add click feedback and loading states to About dialog update but…

2c7bca4

…tons

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

src/desktop/updater.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

src/desktop/updater.ts Outdated Show resolved Hide resolved

fix: derive updater feed owner/repo from package.json

f0cb920

ibetitsmike force-pushed the mike/stable-latest-update-channels branch from 9dcb939 to f0cb920 Compare February 20, 2026 14:20

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

src/browser/components/About/AboutDialog.tsx Outdated Show resolved Hide resolved

fix: clear pendingAction via .finally() to handle backend no-ops

562dc69

ibetitsmike added this pull request to the merge queue Feb 20, 2026

Merged via the queue into main with commit 0a5565b Feb 20, 2026
23 checks passed

ibetitsmike deleted the mike/stable-latest-update-channels branch February 20, 2026 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

🤖 feat: add stable/nightly Electron update channels#2430

🤖 feat: add stable/nightly Electron update channels#2430
ibetitsmike merged 13 commits intomainfrom
mike/stable-latest-update-channels

ibetitsmike commented Feb 14, 2026 •

edited

Loading

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 20, 2026

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

ibetitsmike commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Implementation

Config layer (src/node/config.ts)

Desktop updater (src/desktop/updater.ts)

oRPC surface (src/common/orpc/schemas/api.ts, src/node/orpc/router.ts)

Frontend (src/browser/components/About/AboutDialog.tsx)

Button press feedback (src/browser/components/ui/button.tsx)

CI: manifest naming (scripts/set-package-version.js)

Validation

Risks

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 20, 2026

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ibetitsmike commented Feb 14, 2026 •

edited

Loading

Config layer (`src/node/config.ts`)

Desktop updater (`src/desktop/updater.ts`)

oRPC surface (`src/common/orpc/schemas/api.ts`, `src/node/orpc/router.ts`)

Frontend (`src/browser/components/About/AboutDialog.tsx`)

Button press feedback (`src/browser/components/ui/button.tsx`)

CI: manifest naming (`scripts/set-package-version.js`)