feat: add tool usage recording for blocking responses interceptor#122
Merged
feat: add tool usage recording for blocking responses interceptor#122
Conversation
Contributor
Author
pawbana
force-pushed
the
pb/responses-record-tool-usage
branch
2 times, most recently
from
b0290a7 to
ee80a4b
Compare
mtojek
reviewed
Jan 16, 2026
intercept/responses/base_test.go
Outdated
| expected: nil, | ||
| }, | ||
| { | ||
| name: "nested_object", |
responses_integration_test.go
Outdated
Comment on lines
204
to
205
| recordedTools[0].InterceptionID = tc.expectToolRecorded.InterceptionID // ignore interception id | ||
| recordedTools[0].CreatedAt = tc.expectToolRecorded.CreatedAt // ignore time |
Member
There was a problem hiding this comment.
alternatively you can clear both fields if ignored
intercept/responses/base.go
Outdated
| func (i *responsesInterceptionBase) parseJSONArgs(raw string) recorder.ToolArgs { | ||
| if trimmed := strings.TrimSpace(raw); trimmed != "" { | ||
| var args recorder.ToolArgs | ||
| if err := json.Unmarshal([]byte(trimmed), &args); err == nil { |
Member
There was a problem hiding this comment.
should we do something if JSON is borked?
Collaborator
There was a problem hiding this comment.
Agreed; errors should be handled.
Contributor
Author
There was a problem hiding this comment.
Thanks. Logic was wrong here. Updated it to match what is done in chat completions.
| ID: "resp_789", | ||
| Output: []oairesponses.ResponseOutputItemUnion{ | ||
| { | ||
| Type: "function_call", |
Member
There was a problem hiding this comment.
hm... do we need another test for function_call with broken args?
This was referenced Jan 16, 2026
intercept/responses/base.go
Outdated
| } | ||
| } | ||
|
|
||
| func (i *responsesInterceptionBase) parseJSONArgs(raw string) recorder.ToolArgs { |
Collaborator
There was a problem hiding this comment.
This method isn't well named. It should indicate that it's just for tools.
intercept/responses/base.go
Outdated
| func (i *responsesInterceptionBase) parseJSONArgs(raw string) recorder.ToolArgs { | ||
| if trimmed := strings.TrimSpace(raw); trimmed != "" { | ||
| var args recorder.ToolArgs | ||
| if err := json.Unmarshal([]byte(trimmed), &args); err == nil { |
Collaborator
There was a problem hiding this comment.
Agreed; errors should be handled.
intercept/responses/base.go
Outdated
| // recodring other function types to be considered: https://github.com/coder/aibridge/issues/121 | ||
| switch item.Type { | ||
| case "function_call": | ||
| args = i.parseJSONArgs(item.Arguments) |
Collaborator
There was a problem hiding this comment.
Why is this necessary to do? Why can't we pass the string value like we do for the others?
By the time it's stored in the db it's a string anyway.
Contributor
Author
There was a problem hiding this comment.
Just wanted to keep it consistent with chat completions.
You are right this seems redundant with how we store things in DB but then recorder API should change (ToolUsageRecord should have Args as string instead of any)?
responses_integration_test.go
Outdated
| recordedTools := mockRecorder.RecordedToolUsages() | ||
| if tc.expectToolRecorded != nil { | ||
| require.Len(t, recordedTools, 1) | ||
| recordedTools[0].InterceptionID = tc.expectToolRecorded.InterceptionID // ignore interception id |
Collaborator
There was a problem hiding this comment.
Please provide a reason why.
pawbana
force-pushed
the
pb/responses-record-tool-usage
branch
from
8ecf6e4 to
7bdf03a
Compare
pawbana
force-pushed
the
pb/responses-record-tool-usage
branch
from
7bdf03a to
11d3c46
Compare
Contributor
Author
SasSwart
added a commit
to coder/coder
that referenced
this pull request
Jan 20, 2026
Update our dependency on coder/aibridge. This allows us to benefit from the following additions to bridge: feat: inner agentic loop for openai responses requests (blocking only) (coder/aibridge#127) feat: req/resp logging middleware (coder/aibridge#105) perf: eliminate unnecessary json marshalling for anthropic requests to bridge (coder/aibridge#102) feat: add token usage recording for responses streaming interceptor (coder/aibridge#125) feat: add token usage recording for responses blocking interceptor (coder/aibridge#124) feat: add tool usage recording to streaming responses interceptor (coder/aibridge#123) feat: add tool usage recording for blocking responses interceptor (coder/aibridge#122) Extend circuit breaker functionality to support per-model isolation (coder/aibridge#111) feat: add circuit breaker for upstream provider overload protection (coder/aibridge#75) chore: change blocking request timeouts to 10m (coder/aibridge#118) feat: add prompt recording for responses API (coder/aibridge#109) feat: add basic responses API interceptor (coder/aibridge#107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.