perf: eliminate unnecessary json marshalling for anthropic requests to bridge #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
SasSwart
reviewed
Jan 13, 2026
Contributor
SasSwart
left a comment
SasSwart
left a comment
There was a problem hiding this comment.
I've reviewed the PR structurally, and I only have one comment about test coverage. The rest looks good.
At a higher level I'm a little concerned that we might not sufficiently document why we need to do this kind of content modification.
Its a seemingly invalid assumption of mine that because Bridge acts as a gateway, there should be no discrepancies between the payloads we receive and the ones we track or send on.
Yet, we need to introduce the stream attribute, and me need to coerce tool calls into a specific format and I've been unable to determine why.
| checkContent: nil, | ||
| }, | ||
| { | ||
| name: "mcp_tool_result with string content unchanged", |
Contributor
There was a problem hiding this comment.
Is this test case (and others related to tool_result, mcp_tool_result) no longer relevant? We still have logic in convertStringContentRecursive that relates to these types of content.
SasSwart
approved these changes
Jan 14, 2026
SasSwart
changed the title
Contributor
Merge activity
|
Signed-off-by: Danny Kopping <[email protected]>
SasSwart
force-pushed
the
marshal-once
branch
from
14690bd to
78c808d
Compare
SasSwart
added a commit
to coder/coder
that referenced
this pull request
Jan 20, 2026
Update our dependency on coder/aibridge. This allows us to benefit from the following additions to bridge: feat: inner agentic loop for openai responses requests (blocking only) (coder/aibridge#127) feat: req/resp logging middleware (coder/aibridge#105) perf: eliminate unnecessary json marshalling for anthropic requests to bridge (coder/aibridge#102) feat: add token usage recording for responses streaming interceptor (coder/aibridge#125) feat: add token usage recording for responses blocking interceptor (coder/aibridge#124) feat: add tool usage recording to streaming responses interceptor (coder/aibridge#123) feat: add tool usage recording for blocking responses interceptor (coder/aibridge#122) Extend circuit breaker functionality to support per-model isolation (coder/aibridge#111) feat: add circuit breaker for upstream provider overload protection (coder/aibridge#75) chore: change blocking request timeouts to 10m (coder/aibridge#118) feat: add prompt recording for responses API (coder/aibridge#109) feat: add basic responses API interceptor (coder/aibridge#107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions of determining whether to use Anthropic's streaming APIs and ensuring a uniform message payload format used to unmarshal and remarshal the same payload twice. This PR ensures we unmarshal once, do both, and then remarshal once.