refactor: update Console::run() to allow it be called in command() function#10080
Merged
paulbalandan merged 7 commits intocodeigniter4:4.8from Apr 5, 2026
Merged
refactor: update Console::run() to allow it be called in command() function#10080paulbalandan merged 7 commits intocodeigniter4:4.8from
Console::run() to allow it be called in command() function#10080paulbalandan merged 7 commits intocodeigniter4:4.8from
Conversation
a7fdc17 to
2c1f8cc
Compare
michalsn
reviewed
Mar 31, 2026
5c4f7b7 to
51f329d
Compare
5b06f27 to
0f177c3
Compare
Member
Author
|
I reverted the deprecation on |
michalsn
reviewed
Apr 5, 2026
0f177c3 to
d1fce21
Compare
michalsn
approved these changes
Apr 5, 2026
d1fce21 to
7d5c7d1
Compare
7d5c7d1 to
4bb97c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This refactors
Console::run()so that it can accept a list of tokens to parse (defaulting to$_SERVER['argv']if empty) whenrun()is called. This consequently allows it to be called inside thecommand()function so that the latter can also enjoy the enhancements to command line parsing.A behavior break that I am seeing is that
command()now receives the$paramsas a merge of arguments and options, instead of the previous how-it-was-parsed order. However, since getting the params passed to a command by this function is not an intended use, I believe its impact is minimal.Checklist: