This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Turn labelanalysis and staticanalysis views into noops#1233
Open
Turn labelanalysis and staticanalysis views into noops#1233
labelanalysis and staticanalysis views into noops#1233Conversation
Contributor
✅ Sentry found no issues in your recent changes ✅ |
As part of deprecating ATS, this turns all the views into noops that return empty objects. Checking in with the requests that the CLI sends, returning an empty `external_id` and `absent_labels` for the labelanalysis will result in the CLI falling back to using the clientside requested labels. Similarly, returning an empty list of `filepaths` means that the CLI will not do any further uploads.
Swatinem
force-pushed
the
swatinem/noop-analysis
branch
from
5ee2450 to
51da428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of deprecating ATS, this turns all the views into noops that return empty objects.
Checking in with the requests that the CLI sends, returning an empty
external_idandabsent_labelsfor the labelanalysis will result in the CLI falling back to using the clientside requested labels.Similarly, returning an empty list of
filepathsmeans that the CLI will not do any further uploads.