Skip to content

Correct TypeScript type definitions for effect functions #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavertMik merged 1 commit into from
Jan 18, 2026
Merged

Correct TypeScript type definitions for effect functions #5395

DavertMik merged 1 commit into from
Jan 18, 2026
+3 −3

Conversation

@DenysKuchma
Copy link
Collaborator

@DenysKuchma DenysKuchma commented Jan 16, 2026

#5205

Changes:

  • TryTo: now correctly returns Promise instead of Promise<T | false>
  • HopeThat: now correctly returns Promise instead of Promise<T | false>
  • RetryTo: now accepts (fn: (tries: number) => Promise | void, maxTries: number, pollInterval?: number) and returns Promise

@DenysKuchma DenysKuchma requested a review from DavertMik January 16, 2026 12:38
@DavertMik DavertMik merged commit d10f653 into 4.x Jan 18, 2026
10 checks passed
@DavertMik DavertMik deleted the bugfix/5205-correct-typings-for-effect-functions branch January 18, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DenysKuchma @DavertMik