You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
what's this all about? What is the purpose? Which problem did you solve?
According to the comment
// The backend SSE stream re-publishes the new application (with the migrated
// instance) and then the previous application with an empty instance list so
// the store can drop it. The instance's registration.name changes while the
// id/healthUrl stay the same.
I think he's trying to fix the renaming of an application.
What puzzles me is, how is he doing it?. Is he doing it at runtime somehow?
That's the only scenario - in the context of the change - where I think indeed there may be some issues in the current codebase.
Moreover, the model objects should not be changed.
If this is allowed, I would then argue that the suggestion provided in #5416 to just change the status update event to carry also the health groups should have also be applied instead of having yet another cache and another scheduler that take up resources.
But, that suggestion was rejected by @ulischulte exactly because the model should not be touched since it's exposed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.