Open
Conversation
these libraries were unused the npm.js script also appears to be used, perhaps from a prior build that used grunt or another npm build script
we are tracking the node_modules folder and not using npm in a typical manner this commit removes the node_modules folder and moves the (tracked) bootstrap dependency into our _scss folder, which then allows us to remove the npm package.json and lock file we are using jquery and popper.js but we weren't referencing the files in node_modules but ones in CDNs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two commits that remove a lot of code which shouldn't be needed anymore. I can split it up if we would rather consider the commits independently.
The first commit removes the combined Modernizr + Respond.js script referenced in _includes/header.html, see #66. This code isn't relevant given the features of modern web browsers.
The second commit removes the entire node_modules folder, package.json, package-lock.json, and moves the Bootstrap SCSS files into assets/_scss while updating one reference to the bootstrap.scss index file. We were not using
npmnormally and tracking a node_modules folder is rather unusual. This removes many files and I do not think it makes updating Bootstrap in the future much more difficult.Test Plan
There should be no visible effect on the site, but because this removes a lot of code, I tested comprehensively:
Then repeat all of these steps using a mobile view, e.g. in browser dev tools. It's also good to look for JS errors in the browser's console due to missing files.