Skip to content

feature: default docker scout to 1.19.0 in the sbt job - #249

Open
andrzej-janczak wants to merge 1 commit into
masterfrom
bump-scout-default
Open

feature: default docker scout to 1.19.0 in the sbt job#249
andrzej-janczak wants to merge 1 commit into
masterfrom
bump-scout-default

Conversation

@andrzej-janczak

Copy link
Copy Markdown
Contributor

Problem: scout 0.13.1 cannot re-read the blobs it writes to /tmp/docker-scout on the
Docker engine in ubuntu-2004:2024.08.1, so the scan step fails after a successful build.
The machine image moved at 12.1.4; the scout default never moved across 14 releases.

Fix: default docker_scout_version to 1.19.0 in the sbt job. Five repos already run
1.19.0 on that image, so it is the version with the most evidence.

Unblocks OD-560. 13 repos ride the stale default and 12 of them are pinned below 12.1.4,
so bumping them without this would break them rather than fix them.

0.13.1 cannot re-read the blobs it writes to /tmp/docker-scout on the Docker
engine in ubuntu-2004:2024.08.1, so the scan fails after a successful build.
The image moved at 12.1.4; the scout default never moved.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the default docker_scout_version to 1.19.0 to resolve cache compatibility issues on newer Ubuntu machine images. While the functional change is correct and Codacy reports the PR is up to standards, there is a gap in the acceptance criteria: the update lacks an inline comment explaining the rationale for the change. This documentation is necessary to explain the dependency on the 2024.08 machine image for future maintainers.

Test suggestions

  • Verify that the SBT job successfully installs and runs docker-scout version 1.19.0 when the parameter is not explicitly provided.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the SBT job successfully installs and runs docker-scout version 1.19.0 when the parameter is not explicitly provided.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant