feature: default docker scout to 1.19.0 in the sbt job - #249
feature: default docker scout to 1.19.0 in the sbt job#249andrzej-janczak wants to merge 1 commit into
Conversation
0.13.1 cannot re-read the blobs it writes to /tmp/docker-scout on the Docker engine in ubuntu-2004:2024.08.1, so the scan fails after a successful build. The image moved at 12.1.4; the scout default never moved.
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default docker_scout_version to 1.19.0 to resolve cache compatibility issues on newer Ubuntu machine images. While the functional change is correct and Codacy reports the PR is up to standards, there is a gap in the acceptance criteria: the update lacks an inline comment explaining the rationale for the change. This documentation is necessary to explain the dependency on the 2024.08 machine image for future maintainers.
Test suggestions
- Verify that the SBT job successfully installs and runs docker-scout version 1.19.0 when the parameter is not explicitly provided.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the SBT job successfully installs and runs docker-scout version 1.19.0 when the parameter is not explicitly provided.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Problem: scout 0.13.1 cannot re-read the blobs it writes to
/tmp/docker-scouton theDocker engine in
ubuntu-2004:2024.08.1, so the scan step fails after a successful build.The machine image moved at 12.1.4; the scout default never moved across 14 releases.
Fix: default
docker_scout_versionto 1.19.0 in the sbt job. Five repos already run1.19.0 on that image, so it is the version with the most evidence.
Unblocks OD-560. 13 repos ride the stale default and 12 of them are pinned below 12.1.4,
so bumping them without this would break them rather than fix them.