Skip to content

DOC-15572: Product Change- PR #158961 - cli: set database user name in debug.zip and tsdump generation#22035

Merged
florence-crl merged 3 commits intomainfrom
DOC-15572
Feb 17, 2026
Merged

DOC-15572: Product Change- PR #158961 - cli: set database user name in debug.zip and tsdump generation#22035
florence-crl merged 3 commits intomainfrom
DOC-15572

Conversation

@florence-crl
Copy link
Copy Markdown
Contributor

@florence-crl florence-crl commented Jan 6, 2026

Fixes DOC-15572

In cockroach-debug-zip.md and cockroach-debug-tsdump.md, added --user flag to Client connection section.

Rendered previews

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 6, 2026

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 1331284
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/698f782ad41e550008b792ca

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 6, 2026

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 1331284
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/698f782a93791b00084e5b79

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 6, 2026

@florence-crl florence-crl requested a review from aa-joshi January 6, 2026 18:11
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 6, 2026

Netlify Preview

Name Link
🔨 Latest commit 1331284
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/698f782a22406400086d681d
😎 Deploy Preview https://deploy-preview-22035--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

`--host` | The server host and port number to connect to. This can be the address of any node in the cluster.<br><br>**Env Variable:** `COCKROACH_HOST`<br>**Default:** `localhost:26257`
`--insecure` | Use an insecure connection.<br><br>**Env Variable:** `COCKROACH_INSECURE`<br>**Default:** `false`
<a name="sql-flag-url"></a> `--url` | A [connection URL]({% link {{ page.version.version }}/connection-parameters.md %}#connect-using-a-url) to use instead of the other arguments. To convert a connection URL to the syntax that works with your client driver, run [`cockroach convert-url`]({% link {{ page.version.version }}/connection-parameters.md %}#convert-a-url-for-different-drivers).<br><br>**Env Variable:** `COCKROACH_URL`<br>**Default:** no URL
`--user` | The [SQL user]({% link {{ page.version.version }}/create-user.md %}) that will own the client session.<br><br>**Default:** `root`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explicitly mention that the debug.zip expects user as either root or debug_user for successful debug.zip generation.
wdyt @kevin-v-ngo ?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should explicitly mention that the debug.zip expects user as either root or debug_user for successful debug.zip generation. wdyt @kevin-v-ngo ?

Agree we should call out that root and debug_user should be specified to collect all contents of Debug zip.

But @aa-joshi, aren't we able to still specify any SQL user for the SQL requests the Debug zip make to CRDB?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the later is not supported, we should fix the doc in previous releases and only call out root and debug_user.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-v-ngo The authorisation layer doesn't allow to connect apart from root and debug_user. In future, there is plan to generate debug.zip with any SQL user with essential permissions. @florence-crl Let's make it explicitly that only root and debug_user is allowed.

Copy link
Copy Markdown

@aa-joshi aa-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@peachdawnleach peachdawnleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florence-crl florence-crl merged commit f55b362 into main Feb 17, 2026
6 checks passed
@florence-crl florence-crl deleted the DOC-15572 branch February 17, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants